Copilot commented on code in PR #13107:
URL: https://github.com/apache/trafficserver/pull/13107#discussion_r3114077573
##########
plugins/compress/configuration.cc:
##########
@@ -359,9 +359,11 @@ Configuration::Parse(const char *path)
c->add_host_configuration(current_host_configuration);
} else if (token == "supported-algorithms") {
current_host_configuration->add_compression_algorithms(line_view);
+ line_view.clear();
state = ParserState::Start;
} else if (token == "compressible-status-code") {
current_host_configuration->add_compressible_status_codes(line_view);
+ line_view.clear();
state = ParserState::Start;
Review Comment:
This change fixes parsing of comma/space-separated lists by consuming the
rest of the line, but there’s no regression test ensuring we don’t emit `failed
to interpret` warnings for lines like `supported-algorithms gzip, br` or
`compressible-status-code 200, 206`. Please add a gold test (or extend an
existing compress plugin gold test) that loads such a config and asserts the
diags log does not contain `failed to interpret` for those tokens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
