bneradt commented on code in PR #13143:
URL: https://github.com/apache/trafficserver/pull/13143#discussion_r3203767938


##########
plugins/esi/combo_handler.cc:
##########
@@ -712,7 +712,7 @@ parseQueryParameters(const char *query, int query_len, 
ClientRequest &creq)
         }
       }
       param_start_pos = i + 1;
-    } else if (query[i] == ':') {
+    } else if ((query[i] == ':') && (colon_pos < param_start_pos)) {
       colon_pos = i;

Review Comment:
   Basically: make sure colon_pos hasn't been set yet before setting it in case 
there is a `:` in the path too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to