bneradt commented on code in PR #13151:
URL: https://github.com/apache/trafficserver/pull/13151#discussion_r3227879847
##########
include/iocore/aio/AIO.h:
##########
@@ -82,8 +82,8 @@ struct AIOCallback : public Continuation {
int64_t aio_result = 0;
AIO_Reqs *aio_req = nullptr;
ink_hrtime sleep_time = 0;
- bool from_api = false;
- SLINK(AIOCallback, alink); /* for AIO_Reqs::aio_temp_list */
+ bool from_api = false; ///< Whether the TS API created this callback.
Review Comment:
I guess I'm embarrassing myself here, but I added that comment explicitly
because it wasn't clear to me when I was first studying this use-after-free bug
that `from_api` meant "from the external TS API". It wasn't obvious what API
was being referred to. I suppose I can rename to `from_ts_api`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
