Copilot commented on code in PR #13180:
URL: https://github.com/apache/trafficserver/pull/13180#discussion_r3270692462


##########
tools/hrw4u/grammar/hrw4u.g4:
##########
@@ -88,6 +88,7 @@ AND           : '&&';
 OR            : '||';
 TILDE         : '~';
 NOT_TILDE     : '!~';
+BANG          : '!';
 COLON         : ':';

Review Comment:
   Adding the new lexer token `BANG` will cause ANTLR syntax errors to 
reference `BANG` in expected-token lists. The error humanizer map in 
`tools/hrw4u/src/errors.py` currently has no entry for `BANG`, so user-facing 
parse errors will likely regress to showing the raw token name. Add a 
`_TOKEN_NAMES['BANG'] = "'!'"` mapping (and recompile the regex) so diagnostics 
stay readable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to