On Tue, Dec 11, 2012 at 1:32 AM, Marius Mårnes Mathiesen
<zmalltal...@zmalltalker.com> wrote:
> However, there's an if clause around that call: `unless
> committerships.any?{|c|c.committer == another_owner}` which means that
> if the new owner already has access to the repository, a new
> committership is not created. Could this be what happened on your
> server?Thank you very much for the detailed explanation. Unfortunately I was not personally involved in the transfer actions, and I asked the person who did the transfers. He said that the groups were not on the ACL at the time, so maybe there was another reason. > Whether it is or not, I would suggest that we change it to > either create a new committership or change the permissions to the > existing one, but I'd like to know if that was the cause or you found > another bug. I agree. In my mind the concept of "owner" should imply "full rights". Should we just remove the "unless committerships.any" conditional around the create_for_owner() call in app/models/repository.rb ? - Ken -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
