> I've added preliminary support for HTTPS web hooks:
>
> https://gitorious.org/~ktdreyer/gitorious/ktdreyers-mainline/commits/https-webhooks

Cool!

> I'm a newbie to Ruby testing so please be kind :-) ... I'm not sure
> how to update the unit tests to match this change. See my "FIXME"
> lines in test/unit/processors/web_hook_processor_test.rb. I can't just
> mock Net::HTTP's post_form anymore. Can someone tell me how I should
> adjust the unit tests?

Well, the old test simply stubs the method being used. In your updated
example that's not going to turn out pretty. I suggest giving FakeWeb a
look: https://github.com/chrisk/fakeweb

Let me know if you need some help making it work.

>
> Assuming I can get the tests adjusted, I'd like to submit a merge
> request to get this into mainline.

Sweet!

Christian

-- 
-- 
To post to this group, send email to gitorious@googlegroups.com
To unsubscribe from this group, send email to
gitorious+unsubscr...@googlegroups.com

--- 
You received this message because you are subscribed to the Google Groups 
"Gitorious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to gitorious+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to