Hey, On Mon, Sep 7, 2009 at 5:02 PM, Johannes Gilger<[email protected]> wrote: > > On 07/09/09 15:46, Pieter de Bie wrote: >> Any other bugs will wait for 0.7.1. > > I think I found a bug related to QuickLook (I've got _no_ idea why I'm > only noticing that now) and Snow Leopard. > > First of, this framework doesn't exist anymore: > /System/Library/PrivateFrameworks/QuickLookUI.framework (AppController.m) > > So the QL-Panel didn't come up anymore. I googled (without finding much) > and found out that when I include > /System/Library/Frameworks/Quartz.framework > the panel reappears. _However_, it doesn't display any files, just says > "No items selected" and the console shows a dubious: > > 2009-09-07 16:56:11.264 GitX[32057:a0b] -[QLPreviewPanel > setURLs:currentIndex:preservingDisplayState:] is deprecated - use > dataSource instead > > Ideas? I know the new QLPreviewPanel doesn't mention setURLs anymore, > but a deprecation-warning should mean it still works (and we've some > time to bring it up-to-date)
I guess they really changed the API now. As it has never been a public API, apple doesn't have to correctly deprecate methods. Apparently they deprecated some, but some just fail. Looking at the new panel interface in 10.6, it looks like we have to implemented in a completely different way. It shouldn't be too hard to do, but I can't do it as I'm not on Snow Leopard yet. What I suggest is creating a custom object that just creates a QLPreviewPanel and calls it in the right way, depending on what OS we currently run. It might even be a subclass of the current QLPreviewPanel, but I'm not sure that will work (as the docs mention it can't be subclassed). I'm not sure how to solve that. If you can write such an object for SL, I can extend it for Leopard, as I'm still on Leopard. Otherwise we can wait until I switch to SL, but it'll be a few months before I can do that. For now, I'd suggest just keeping it broken as it is now, or disabling it if we're on 10.6.
