Hello,
How should we organise with pull requests? Do we want at least one
person to review before merging?
I saw that richelbilderbeek contributed several elements, including
fixes in scons, CI scripts, and a Qt build script in one PR [1], and I
did a review. The first two are for sure highly valuable, the Qt build
script I am not sure that it is helpful, but I won't keep people from
contributing if they want to, if it is useful for them.
On my side, I added out of source build to scons [2] that I would like
to merge, if someone wants to review it is welcome.
cheers,
Stéphane
[1] https://github.com/Globulation2/glob2/pull/6
[2] https://github.com/Globulation2/glob2/pull/7
--
http://stephane.magnenat.net
_______________________________________________
glob2-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/glob2-devel
