A fix cause less problem in PR, the only things will be the test (enough test or not).
But an urgent bug fix not mean a release in urgency, so it can be opened some hours (not some days :p) David ++ Le Fri, 9 Sep 2016 08:55:41 +0000 "Moron, Olivier" <[email protected]> a écrit: >1 day can be very long when it's an urgent bug fix > > >-----Original Message----- >From: Glpi-dev [mailto:[email protected]] On Behalf Of >Alexandre Delaunay Sent: Friday, September 09, 2016 10:47 AM >To: Liste de diffusion des developpeurs GLPI >Subject: Re: [Glpi-dev] Modify coding methods to enhance code quality > >OK for me > >----- Mail original ----- >> De: "Johan Cwiklinski" <[email protected]> >> À: "Liste de diffusion des developpeurs GLPI" <[email protected]> >> Envoyé: Vendredi 9 Septembre 2016 09:35:37 >> Objet: Re: [Glpi-dev] Modify coding methods to enhance code quality >> >> Hello, >> >> > For PR adding a feature / changing a behavior, I think we need to >> > keep it open before merging for some time (1 day ?) so other >> > developpers can comment it (e.g. >> > https://github.com/glpi-project/glpi/pull/945) >> >> OK for me, let's say PR will stay opened one day. >> >> ++ >> -- >> Johan >> >> _______________________________________________ >> Glpi-dev mailing list >> [email protected] >> https://mail.gna.org/listinfo/glpi-dev > >_______________________________________________ >Glpi-dev mailing list >[email protected] >https://mail.gna.org/listinfo/glpi-dev >_______________________________________________ >Glpi-dev mailing list >[email protected] >https://mail.gna.org/listinfo/glpi-dev _______________________________________________ Glpi-dev mailing list [email protected] https://mail.gna.org/listinfo/glpi-dev
