Hi Ravi, On Thu, Oct 15, 2020 at 1:27 PM Ravishankar N <ravishan...@redhat.com> wrote:
> > On 15/10/20 4:36 pm, Sheetal Pamecha wrote: > > > +1 > Just a note to the maintainers who are merging PRs to have patience and > check the commit message when there are more than 1 commits in PR. > > Makes sense. > > >> >> Another thing to consider is that rfc.sh script always does a rebase >>> before pushing changes. This rewrites history and changes all commits of a >>> PR. I think we shouldn't do a rebase in rfc.sh. Only if there are >>> conflicts, I would do a manual rebase and push the changes. >>> >>> >> >> I think we would also need to rebase if say some .t failure was fixed and > we need to submit the PR on top of that, unless "run regression" always > applies your PR on the latest HEAD in the concerned branch and triggers the > regression. > Yes, I agree that sometimes we need a rebase, but I would do that only if necessary by running a manual 'git rebase'. I don't think we can do an automatic rebase before running a regression, because there could be conflicts that cannot be fixed automatically. Xavi > > > Actually True, Since the migration to github. I have not been using > ./rfc.sh and For me it's easier and cleaner. > > > Me as well :) > -Ravi > _______________________________________________ > > Community Meeting Calendar: > > Schedule - > Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC > Bridge: https://bluejeans.com/441850968 > > > > > Gluster-devel mailing list > Gluster-devel@gluster.org > https://lists.gluster.org/mailman/listinfo/gluster-devel > >
_______________________________________________ Community Meeting Calendar: Schedule - Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC Bridge: https://bluejeans.com/441850968 Gluster-devel mailing list Gluster-devel@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-devel
