On 15/11/20 8:24 pm, Strahil Nikolov wrote:
Hello All,

did anyone get a chance to look at 
https://github.com/gluster/glusterfs/issues/1778 ?

A look at https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117 seems to indicate this could be due to a typo error. Do you have a source install where you can apply this simple diff and see if it fixes the issue?

diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
index 558f04fb2..d7bf96adf 100644
--- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
+++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
@@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char **op_errstr)
             }
         } else if (len_strcmp(key, keylen, "ganesha.enable")) {
             key_matched = _gf_true;
-            if (!strcmp(value, "off") == 0) {
+            if (strcmp(value, "off") == 0) {
                 ret = ganesha_manage_export(dict, "off", _gf_true, op_errstr);
                 if (ret)
                     goto out;

Thanks,

Ravi

It's really strange that NFS Ganesha has ever passed the tests.
How do we test NFS Ganesha exporting ?

Best Regards,
Strahil Nikolov
_______________________________________________

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel


_______________________________________________

Community Meeting Calendar:

Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: https://bluejeans.com/441850968




Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel

Reply via email to