Hi,

Am 15.08.2010 22:40, schrieb IOhannes m zmölnig:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> 2nd attempt (this time from my subscribed email address):
>
> in the course of packaging gmerlin-avdecoder i came across a small issue
> with the exported symbols of the library.
> debian keeps track of all those symbols and if symbols vanish, the
> policy requires that the library pkgname changes (e.g. libgmerlin-avdec1
> - ->  libgmerlin-avdec2)
>
> we are building on a package for 1.0.1 and have updated to 1.0.3
> even with this very micro (in version-numbers) update, some exported
> symbols vanished (e.g. "bgav_options_set_seamless")
>
> now i believe, that these symbols are not meant to be "exported" anyhow,
> as they do not show up in any public headers.

bgav_options_set_seamless was a planned feature some years ago, but got never
implemented. If you don't want the library version to change, you can
patch it back in as a NOP in the Debian .tar.gz (restoring the original
"behaviour").

However since the last public release, I got plenty of new functions. So maybe
the version will change anyway.

> in order to make upgrading more seamless, i would like to prevent any
> non-public symbols to be exported.
> i notice that there is already a check for gcc visibility declarations
> ("-fvisibility=hidden") in gmerlin-avdec, which seems to be the simples
> way to go.
> unfortunately, the results of the test are nowhere used (only the
> LIB_CFLAGS variable is updated, but it is mentioned in no Makefile)
>
> is there a reason for this? (e.g. did it break something?)

It was broken, now it works (must be LIBBGAV_CFLAGS instead of LIB_CFLAGS).
The visibility feature not only cleans up the ABI, it also makes the
code more efficient.

Burkhard

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Gmerlin-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gmerlin-general

Reply via email to