Hi, Am 05.05.2011 11:48, schrieb Cristian Morales Vega: > 2011/5/5 Burkhard Plaum<[email protected]>: >> Hi, >> >> Am 05.05.2011 02:19, schrieb Cristian Morales Vega: >>> libgmerlin_gtk uses functions that have been deprecated with GTK 2.24. >>> For example, in lib/gtk/cfg_multi_menu.c:229 there is >>> gtk_combo_box_new_text(). Since "-DGTK_DISABLE_DEPRECATED" is forced >>> that means they are not available but, because of that stupid pre >>> standard implicit declaration thing, the compiler only gives a warning >>> you can easily not see. >>> >>> When compiling with gcc looking for "implicit declaration of function" >>> shows all the functions with the problem. Either the code needs to be >>> updated or -DGTK_DISABLE_DEPRECATED removed from the cflags. >>> >> >> I don't have the newest gtk here so I can't reproduce it. >> But I'd like to fix that. Do you have a complete list of functions, >> which were deprecated? Where they all deprecated in GTK 2.24? > > The list is of uses is > > albumwindow.c:343:3: warning: implicit declaration of function > 'gtk_notebook_set_tab_label_packing' > auth.c:83:3: warning: implicit declaration of function > 'bg_gtk_widget_set_can_default' > cfg_dialog.c:470:3: warning: implicit declaration of function > 'bg_gtk_widget_set_can_default' > cfg_multi_menu.c:229:3: warning: implicit declaration of function > 'gtk_combo_box_new_text' > cfg_multi_menu.c:244:9: warning: implicit declaration of function > 'gtk_combo_box_append_text' > cfg_stringlist.c:147:3: warning: implicit declaration of function > 'gtk_combo_box_new_text' > cfg_stringlist.c:160:7: warning: implicit declaration of function > 'gtk_combo_box_append_text' > driveselect.c:70:5: warning: implicit declaration of function > 'gtk_combo_box_remove_text' > driveselect.c:83:7: warning: implicit declaration of function > 'gtk_combo_box_append_text' > driveselect.c:179:3: warning: implicit declaration of function > 'gtk_combo_box_new_text' > driveselect.c:195:3: warning: implicit declaration of function > 'bg_gtk_widget_set_can_default' > message.c:89:3: warning: implicit declaration of function > 'bg_gtk_widget_set_can_default' > multiinfo.c:80:3: warning: implicit declaration of function > 'bg_gtk_widget_set_can_default' > plugininfo.c:82:3: warning: implicit declaration of function > 'bg_gtk_widget_set_can_default' > pluginmenu.c:72:3: warning: implicit declaration of function > 'gtk_combo_box_new_text' > pluginmenu.c:79:5: warning: implicit declaration of function > 'gtk_combo_box_append_text' > plugin_single.c:401:3: warning: implicit declaration of function > 'gtk_combo_box_new_text' > plugin_single.c:408:5: warning: implicit declaration of function > 'gtk_combo_box_append_text' > question.c:95:3: warning: implicit declaration of function > 'bg_gtk_widget_set_can_default' > textwindow.c:78:3: warning: implicit declaration of function > 'bg_gtk_widget_set_can_default' > urlselect.c:155:3: warning: implicit declaration of function > 'bg_gtk_widget_set_can_default' > g_control.c:460:9: warning: implicit declaration of function > 'gtk_range_set_update_policy' > g_control.c:532:9: warning: implicit declaration of function > 'gtk_combo_box_new_text' > g_control.c:539:11: warning: implicit declaration of function > 'gtk_combo_box_append_text' > gmerlin_visualizer.c:390:5: warning: implicit declaration of function > 'bg_gtk_widget_set_can_focus' > > > So the functions are > > gtk_notebook_set_tab_label_packing -> deprecated since 2.20 > gtk_combo_box_append_text -> deprecated since 2.24 > gtk_combo_box_new_text -> deprecated since 2.24 > gtk_combo_box_remove_text -> deprecated since 2.24 > gtk_range_set_update_policy -> deprecated since 2.24
Ok, I just made a commit, which fixes all those. > > Plus bg_gtk_widget_set_can_default and bg_gtk_widget_set_can_focus... > I think they are my fault. The functions are defined in gtkutils.c but > are not declared in gtkutils.h. No, they were my fault. Added them to gtkutils.h. Burkhard ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Gmerlin-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gmerlin-general
