Hi, Am 11.06.2012 17:47, schrieb IOhannes m zmoelnig: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 2012-06-11 14:47, IOhannes m zmoelnig wrote: >> On 2012-06-08 23:13, Burkhard Plaum wrote: >> > > and i found a small issue when trying to compile gmerlin-encoders with > the ffmpeg/libav implementation found in debian. > > #1 is that plugins/ffmpeg/ffmpeg_common.c tries to access the struct > member "samples_written" in an ENCODE_AUDIO2 protected zone, whereas > the struct member is only defined in an ENCODE_VIDEO2 protected zone. > changing the ifdef in plugins/ffmpeg/ffmpeg_common.h to ENCODE_AUDIO2 > makes it compile. (see attached encode_audio.patch)
Applied. > #2 before finding out that the actual build fix is so simple, i > noticed that a lot of code is protected with liberal use of version > checks like "#if LIBAVCODEC_VERSION_MAJOR>= 54". > it seems that these checks are mostly too strict, as Debian does not > come yet with such versions but still provides the protected symbols. > the attached libav.patch tries to use more fine-grained version numbers. > the numbers i used come from what i found on the web, and i only > tested, whether the thing compiles :-) Well it's the question whether to make the check against the version when a new API was introduced (deprecating the old one) or when the old API got removed. The first option is difficult because sometimes the ffmpeg developers forget to increase the version number after adding a new API. In the other hand browsing the ffmpeg git history and look for things like [1]: -#ifndef FF_API_OLD_METADATA2 -#define FF_API_OLD_METADATA2 (LIBAVFORMAT_VERSION_MAJOR < 54) -#endif is simple enough. Certainly depracation warnings are annoying (and I reduced them to zero when I did the API update), but they will come back anyway with future ffmpeg/libav versions :) Anyway thanks a lot Burkhard [1] http://git.videolan.org/?p=ffmpeg.git;a=blobdiff;f=libavformat/version.h;h=b362352f2edfa53d9a56a001b624af1517092ed1;hp=b15e03fd2ca13ac98cd2d83912e561213911b7c7;hb=38233fc13106627e05add93df227ec72a11ed24a;hpb=2439f2ca82e28aa38b8aa2512bdb5a328e946cb9 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Gmerlin-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gmerlin-general
