Ciao, Il Gio, 27 Dicembre 2012 12:12 pm, Niels ha scritto: > Torbjorn Granlund <t...@gmplib.org> writes: >> I thought we had discussed this. The change is fine, optimising the >> common case is a great thing in general.
Unfortunately, the common case is not tested by our testsuite! http://hydra.nixos.org/build/3594794/download/1/coverage/mpz/combit.c.gcov.html Only check-mini-gmp stress-tests it ;-) >> Do you want the suggested incompatible change listed on the incompatible >> web page? > Maybe it would be good to keep that file in the repo? That's a good idea. About mpz_combit code, may I suggest replacing the two lines MPN_NORMALIZE (dp, dsize); ASSERT (dsize > 0); with MPN_NORMALIZE_NOT_ZERO (dp, dsize); ? Regards, m -- http://bodrato.it/papers/ _______________________________________________ gmp-devel mailing list gmp-devel@gmplib.org http://gmplib.org/mailman/listinfo/gmp-devel
