Hello,

Here is a patch  which does 2 things:

* simplify check handling by putting testsuite in SUBDIRS and mark
  check programs as check_ instead of noinst_

* add smart_ptr.hpp to distributed files

make distcheck choke on 
ERROR: files left in build directory after distclean:
./testsuite/libbase/gnash-dbg.log

Indeed some gnash-dbg.log are left after make check:
./testsuite/actionscript.all/gnash-dbg.log
./testsuite/libbase/gnash-dbg.log

What is the proper fix? Should these files be removed with make clean
or should the tests be fixed such that they are not generated?

--
Pat
? libbase/out
? testsuite/actionscript.all/gnash-dbg.log
? testsuite/actionscript.all/out.swf
? testsuite/libbase/gnash-dbg.log
Index: Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/Makefile.am,v
retrieving revision 1.36
diff -u -3 -p -r1.36 Makefile.am
--- Makefile.am 2 Oct 2006 16:32:39 -0000       1.36
+++ Makefile.am 3 Oct 2006 11:47:53 -0000
@@ -44,7 +44,8 @@ STD_DIRS = \
        server \
        backend \
        gui \
-       utilities
+       utilities \
+       testsuite
 
 if PLUGIN
 PLUGIN_DIRS = plugin
@@ -61,7 +62,7 @@ endif
 SUBDIRS      = $(STD_DIRS) $(DOC_DIRS) $(PLUGIN_DIRS) $(KLASH_DIRS)
 
 # libamf isn't used yet, but we still want it in the distribution
-DIST_SUBDIRS = $(STD_DIRS) doc testsuite plugin
+DIST_SUBDIRS = $(STD_DIRS) doc plugin
 
 #EXTRA_DIST = macros
 # if HTTP
@@ -94,8 +95,6 @@ snapshot: distdir
 mudflap:
        @echo "Rebuilding with GCC Mudflap support"
        $(MAKE) CXXFLAGS="$(CXXFLAGS) -fmudflap" LDFLAGS="$(LDFLAGS) -lmudflap"
-check:
-       (cd testsuite ; $(MAKE) check $(RUNTESTFLAGS) )
 
 dumpconfig:
        @uname -a
Index: libbase/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/libbase/Makefile.am,v
retrieving revision 1.39
diff -u -3 -p -r1.39 Makefile.am
--- libbase/Makefile.am 29 Sep 2006 22:20:46 -0000      1.39
+++ libbase/Makefile.am 3 Oct 2006 11:47:53 -0000
@@ -119,6 +119,7 @@ noinst_HEADERS = \
        ogl.h \
        postscript.h \
        rc.h \
+       smart_ptr.hpp \
        smart_ptr.h \
        triangulate.h \
        triangulate_impl.h \
Index: testsuite/libbase/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/testsuite/libbase/Makefile.am,v
retrieving revision 1.7
diff -u -3 -p -r1.7 Makefile.am
--- testsuite/libbase/Makefile.am       29 Sep 2006 22:20:46 -0000      1.7
+++ testsuite/libbase/Makefile.am       3 Oct 2006 11:47:53 -0000
@@ -74,7 +74,7 @@ INCLUDES = -I.. \
 
 abs_builddir=$(shell cd $(top_builddir)/testsuite/libbase; pwd)
 
-noinst_PROGRAMS = \
+check_PROGRAMS = \
        CurlStreamTest  \
        NoSeekFileTest \
        URLTest \
Index: testsuite/misc-ming.all/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/testsuite/misc-ming.all/Makefile.am,v
retrieving revision 1.11
diff -u -3 -p -r1.11 Makefile.am
--- testsuite/misc-ming.all/Makefile.am 20 Sep 2006 16:20:39 -0000      1.11
+++ testsuite/misc-ming.all/Makefile.am 3 Oct 2006 11:47:53 -0000
@@ -52,7 +52,7 @@ INCLUDES = -I.. \
         $(MING_CFLAGS)
 
 
-noinst_PROGRAMS = \
+check_PROGRAMS = \
        moviecliploader_test \
        definebitsjpeg2 \
        DefineEditTextTest \
_______________________________________________
Gnash-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/gnash-dev

Reply via email to