Dnia 25.02.2009 Rob Savoye <r...@welcomehome.org> napisaĆ/a: > There are likely a few bugs in this release, but my main concern is > stability and adequate performance. I'd appreciate some feedback on > whether these work for everyone. I'm also interested in any build & > config issues on *BSD, open embedded, other platforms, etc...
Thanks for providing the snapshot. I have tried to compile this on FreeBSD: (1) When building gprocessor I get undefined references in libgnashmedia.so .../gnash-trunk_20090225/libmedia/.libs/libgnashmedia.so: undefined reference to `sws_getContext(int, int, int, int, int, int, int, SwsFilter*, SwsFilter*, double*)' undefined reference to `sws_freeContext(SwsContext*)' undefined reference to `sws_scale(SwsContext*, unsigned char**, int*, int, int, unsigned char**, int*)' The fix is easy: --- libmedia/ffmpeg/VideoConverterFfmpeg.h.orig 2009-02-26 22:11:26.163319075 +0100 +++ libmedia/ffmpeg/VideoConverterFfmpeg.h 2009-02-26 22:13:28.942914343 +0100 @@ -29,7 +29,9 @@ #include "log.h" #if HAVE_SWSCALE_H +extern "C" { #include <libswscale/swscale.h> +} #endif (2) Many systems don't have POLRDHUP for poll(2), it should probably autodetected. The patch below let me compile cygnal. --- cygnal/cygnal.cpp.orig 2009-02-26 22:19:54.613358641 +0100 +++ cygnal/cygnal.cpp 2009-02-26 22:20:22.377814314 +0100 @@ -578,7 +578,7 @@ struct pollfd fds; fds.fd = args->netfd; - fds.events = POLLIN | POLLRDHUP; + fds.events = POLLIN; if (crcfile.getThreadingFlag() == true) { // Each dispatch thread gets it's own argument data and // network connection data. @@ -663,8 +663,8 @@ for (it = hits->begin(); it != hits->end(); it++) { // We got an error, which isn't always a crises, as some are normal // if the client disconnects while we're talking to it. - if ((it->revents & POLLRDHUP) || (it->revents & POLLNVAL)) { - log_debug("Revents has a POLLRDHUP or POLLNVAL set to %d for fd #%d", + if (it->revents & POLLNVAL) { + log_debug("Revents has a POLLNVAL set to %d for fd #%d", it->revents, it->fd); net->erasePollFD(it->fd); net->closeNet(it->fd); The plugin looks nice, *seems* to be smoother, the annoying "Click to play" button does not take 50% of the movie space but resides conveniently at the bottom. Other than that, it looks fine as far as I can tell after 2-minute testing. -- << Marcin Cieslak // sa...@system.pl >> _______________________________________________ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev