Hello Jeff, > Le 14 nov. 2023 à 18:35, Jeffrey R. Carter via Gnoga-list > <[email protected]> a écrit : > > Comments ts based on the 1.7 branch. > > There appears to be an error in function String_To_Pixel_Data, based on the > string returned from function Data (Image_Data_Type) return String: the Y > loop needs to be the outer loop.
Well, one chance out of two to be ... wrong. However, I recall having tested the Data procedure and function against Javascript in canva_test.adb. But maybe the two same errors in both code cancel each other out. Could you please give a reproducer? > In addition, the 4 function calls in the aggregate rely on the order of > evaluation, which is not specified by the language. While GNAT is unlikely to > change this, it's safer to assign the results of the calls to variables and > use them in the aggregate. > > Finally, the initialization of S has no effect. Yes it's typical coding style of David. I guess it isn't the only one in Gnoga. You know Ada better than me but I wonder what was David motivation. > Assuming that the string supplied to procedure Data (Image_Data_Type; String) > has the same format, then the change to the loops also applies to procedure > Data (Image_Data_Type; Pixel_Data_Type). Sure. Regards, Pascal. https://blady.pagesperso-orange.fr _______________________________________________ Gnoga-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gnoga-list
