Hi, I would like to request a hard-code freeze break for Gedit. The patch modifies the signatures in some signals, and it's important and it fixes some crashes experimented by python plugin when listening to those signals.
There are no feature/ ui or string differences regarding this patch. Greetings José PS: As bugzilla is down, I attach the patch here (it's already reviewed by Ignacio Casal, nacho)
From 6cfce4297955e86efc662d9270368267bd9b4680 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Aliste?= <jali...@src.gnome.org> Date: Fri, 25 Mar 2011 07:48:51 -0400 Subject: [PATCH] Fix "Loaded" and "Saved" signal signatures to avoid py plugins from crashing. --- gedit/gedit-document.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gedit/gedit-document.c b/gedit/gedit-document.c index 6070b59..38ce376 100644 --- a/gedit/gedit-document.c +++ b/gedit/gedit-document.c @@ -669,10 +669,10 @@ gedit_document_class_init (GeditDocumentClass *klass) G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GeditDocumentClass, loaded), NULL, NULL, - g_cclosure_marshal_VOID__POINTER, + g_cclosure_marshal_VOID__BOXED, G_TYPE_NONE, 1, - G_TYPE_POINTER); + G_TYPE_ERROR); /** * GeditDocument::save: @@ -720,10 +720,10 @@ gedit_document_class_init (GeditDocumentClass *klass) G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GeditDocumentClass, saved), NULL, NULL, - g_cclosure_marshal_VOID__POINTER, + g_cclosure_marshal_VOID__BOXED, G_TYPE_NONE, 1, - G_TYPE_POINTER); + G_TYPE_ERROR); document_signals[SEARCH_HIGHLIGHT_UPDATED] = g_signal_new ("search-highlight-updated", -- 1.7.3.5
_______________________________________________ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n