For gnome-shell, I've integrated below a list sent to me by Ionut Biru and information about patches in the Fedora 3.0.1 RPM (mostly suggestions from Dan Williams.)
Because of the number of patches *on* these lists, I'm not going to look at all at stuff on master nobody proposed or outstanding uncommitted patches that we might to grab at the last minute. ! Already merged * Planning to merge x Not planning to merge After notes in detail on everything, I've grouped things into categories of what I'm planning to merge and not merge. - Owen > GNOME > Definitely Want To Have: ========================== * d104f9210a8aed12bab7b99f433fe289b96bf808 [Ionut] PopupSliderMenuItem: intercept clicks outside the slider https://bugzilla.gnome.org/show_bug.cgi?id=646660 Sound indicator should provide a mute button Simple patch, fixes an easily reproducible, if minor issue x d2a16bca10fcc3be39895a99a1607483f4e65fdc [Ionut] altTab: Fix the appSwitcher's allocation https://bugzilla.gnome.org/show_bug.cgi?id=647807 App Switcher scrolling is broken This one is simple, but depends on fe08ebd for correct operation, and it's almost imposible to trigger alt-Tab scrolling. x fe08edbe2bf88aa43b643a8f8449dd49a3bafabe [Ionut] altTab: fix Alt+Tab scrolling on initial display https://bugzilla.gnome.org/show_bug.cgi?id=647807 App Switcher scrolling is broken Looks pretty safe, considering that we have undiagnosed crashes when showing altTab already, I'm not really comfortable changing around ordering by forcing an allocation. Does it make it better? Does it make it worse? Who knows. * bafd9c777ade647b2e31f3265ed8970f39f1843c [Ionut] https://bugzilla.gnome.org/show_bug.cgi?id=648765 history: Fix navigation when entering a repeat Safe, localized patch, easy to test and test the fix, but impact is very minor (misbehavior in looking glass only? in chat?) x 0d440bb0a2b3bb277533eb0177b3c7810bf544ea [Ionut] https://bugzilla.gnome.org/show_bug.cgi?id=648894 StTooltip: add missing break statement No user visible impact. (Only possible reason to add this would be an extension using tooltips) * 56d584b7c62bb5d04460d1e0d7abf5c3ac292468 https://bugzilla.gnome.org/show_bug.cgi?id=648983 workspace opacity is wrong after canceled drag Only affects a minor misbehave of a portion of the user interface that people don't usually touch. Patch is superficially completely safe, and easy to test. ! 88de26138a8b79d89884ff2eb6471c5a8e3b39ca shell-xfixes-cursor: missing XFree https://bugzilla.gnome.org/show_bug.cgi?id=642652 Major memory leak on mutter when using gnome-shell ! 72f9f482d6f1bcb53ea2bd1606818af1f33a5a8c st-private: Fix memory leak ! c975740f9228b2c53d79ac08ad704fca5f1c5b6e st-private: Correct fix for memory leak https://bugzilla.gnome.org/show_bug.cgi?id=649497 st-private: Fix memory leak x dcd07eb23ff763c84d898a4d9ec886001220eb49 [Ionut] https://bugzilla.gnome.org/show_bug.cgi?id=649508 StTextureCache: plug leak in not-found icon case Patch is not (fully) correct from my reading, don't think the part of the leak that is fixed is big enough to be worth cherry-picking the patch x fb384fc2910091f86058ae3b0021602796b5e0fe https://bugzilla.gnome.org/show_bug.cgi?id=649633 shell-tp-client: enable client recovery Doesn't make sense in the 3-0 branch - telepathy-glib usage is new in master. x https://bugzilla.gnome.org/show_bug.cgi?id=631576 Use upstream gettext instead the Glib one No end user impact, not a candidate x https://bugzilla.gnome.org/show_bug.cgi?id=649981 Use Shell.get_file_contents_utf8_sync over GLib.file_get_contents No end user impact, not a candidate * 63b1699a35b6206747dac0e8ed2ac583618a9e64 [Ionut] panel: Don't propagate button-release-event in _onCornerClicked() https://bugzilla.gnome.org/show_bug.cgi?id=649427 After triggering the Activities hotcorner, ignore clicks for a split second Very small patch, I gave it some pretty extensive testing; impact isn't big, but if the user happens to have the wrong timing could be annoying. x 48acc41698f21a122f5f920d171fd120218acd35 [Ionut] Don't crash when removing nameless user https://bugzilla.gnome.org/show_bug.cgi?id=647893 gnome-shell restarts when adding/remove an username without a name Sounds like it fixes a major problem, but I can't reproduce, and the patch doesn't make sense to me. x 986d72d9de055a4871e5a213bac5c022ddfd6c49 [Ionut] configure: remove support for evolution-data-server 1.2 > https://bugzilla.gnome.org/show_bug.cgi?id=647395 Can't build due to calendar-server/calendar-sources.h:29:25: fatal error: glib-object.h: No such file or directory Just a cleanup, not relevant for 3.0.x x 71dfab97113d03d0ea722e071f513f53f8572eae [Ionut] altTab: remove erroneous/superflous pick https://bugzilla.gnome.org/show_bug.cgi?id=650317 crash in Alt+Tab due to bad pick I don't think we've root-caused this problem or fixed the crash x bee37b5bc4aa89174b6dc56289383d0f5bb4a200 [Ionut] lookingGlass: make Esc work on any page https://bugzilla.gnome.org/show_bug.cgi?id=647303 Looking Glass don't close with Esc key if it's selected a tab other than Evaluator Not that obvious of a patch, and I'd consider LookingGlass to be a developer-only feature. * 6e6b1e6052b762279b4a8fbaee78f3bb2d690332 [Ionut] workspace: End zooming when starting a window drag https://bugzilla.gnome.org/show_bug.cgi?id=649632 workspace: various fixes for window zooming Patch doesn't work quite as I'd like in testing (reopened bug), but is easy to test, and works better. * bc2b47974dfabfb7dbaa510f1362b0a28fd30af4 [Ionut] workspace: Use Main.uiGroup instead of global.stage https://bugzilla.gnome.org/show_bug.cgi?id=649632 workspace: various fixes for window zooming Minor problem, but simple, easy to test. ========================================================================== > Nice To Have: x a87f51487e51b9c53b87f83ba28b99ded1a3a438 https://bugzilla.gnome.org/show_bug.cgi?id=648305 Display dialogs on the primary monitor when no window has focus. I don't see how the patch changed anything - it looks like just a cleanup though it claims to fix a bug. x 2e02918323937dceeb63df9533a2b272619c408e [Ionut] https://bugzilla.gnome.org/show_bug.cgi?id=645848 WindowOverlay: Show close button after an animation This is fixing a pretty annoying issue, but it creates: https://bugzilla.gnome.org/show_bug.cgi?id=651013 and reveals more obviously: https://bugzilla.gnome.org/show_bug.cgi?id=651012 I'd rather wait until those things were resolved before we considered it 3-0 ready. x https://bugzilla.gnome.org/show_bug.cgi?id=646919 environment: improve Object.toString for delegate objects No end user impact, not a candidate x https://bugzilla.gnome.org/show_bug.cgi?id=646915 panel: provide a consistent way to refer to panel items from lg No end user impact, not a candidate * 74a39ae57cdce50d45dd04ed58b14c7e6b043495 [Ionut] shell-app: Fix a case where last_user_time isn't updated. https://bugzilla.gnome.org/show_bug.cgi?id=643302 Alt-Tab not working with dialog Patch makes things better, though it isn't a complete fix. ! 4e9ef93c0691dab6d90935353e6de981cbddac54 [Fedora] Some icons randomly appear twice https://bugzilla.gnome.org/show_bug.cgi?id=648739 appDisplay: Fix off-by-one when incrementally adding application icons x 8ec62ce46bef65ece1940193493ffd22214208ce [Ionut] https://bugzilla.gnome.org/show_bug.cgi?id=648410 bluetooth: fix mis-spelling of "Set up" String change, not a candidate * 4b3fbc4c9be02f7c039ca832fc9c37295fa42778 [Ionut] network: fix modem connected state check https://bugzilla.gnome.org/show_bug.cgi?id=650124 [patch] fix modem activated patch I'm not sure of the exact impact of this change, but if Dan thinks it's correct, it should be a safe patch. * 73cae8ce9a288876de61e298b44d6eac0c971774 [Ionut] https://bugzilla.gnome.org/show_bug.cgi?id=649596 st-scroll-view: remove spurious assignment of uninitialized data Clearly correct, no impact, but might help people valgrinding the shell. x c4f5274d74a04b88c5a8ba7615ed16b44c6c82a8 [Ionut] appMenu: Disable reactivity at the start of animation https://bugzilla.gnome.org/show_bug.cgi?id=639459 panelMenu: Make the appMenu unclickable when fading out Patch is about a wash - fixes one minor problem, creates another. * ffd461cdb435eb479010bc0831371684f9983f74 [Ionut] telepathyClient: don't update notifications for outgoing messages https://bugzilla.gnome.org/show_bug.cgi?id=650219 Don't update chat notifications with outgoing messages Fixes a confusing bug, I'm pretty confident in the patch Other Patches from Fedora RPM ============================= * 101a07a3d79223cc153a6c65f22acd76cbae4818 [Ionut] network: fix handling of AP flags and enhance for 802.1x https://bugzilla.gnome.org/show_bug.cgi?id=648171 * c31109800b3267df433841bff08c9383a5d669cb [Ionut] network: simplify connection sorting by using libnm-glib functions https://bugzilla.gnome.org/show_bug.cgi?id=648648 * ae0652d13fc2d7caa3d64f2b87d174253cae5901 [Ionut] fix initial connections to WPA[2] Enterprise APs https://bugzilla.gnome.org/show_bug.cgi?id=648171 * 5090a4ccce87643081138272fb8a2fe687f1ed0a [Ionut] network: request that nm-applet show the mobile broadband wizard https://bugzilla.gnome.org/show_bug.cgi?id=649318 Other patches proposed by Ionut =============================== x d0780d16224d7bb2ad183542337c48324fdd2185 NetworkMenu: keep wirelesss networks in predictable order https://bugzilla.gnome.org/show_bug.cgi?id=646580 Added access points cause menu oddities This is a pretty huge improvement, but it's too big of a code change for me to feel comfortable with in 3.0.2. x 42a5531f1588ae3063e7d8ff7642e9f81c13afbd network: fix a variable name Follow-on fix for d0780d16 x 76fce94b66be7bdebbedcc3bce62898da51da15a BluetoothStatus: always update devices https://bugzilla.gnome.org/show_bug.cgi?id=647565 bluetooth extension doesn't show status change for device Sounds like there is substantial user impact, but not sure we've had sufficient testing, and the patch isn't completely obvious. ======================================== Already in gnome-3-0 branch 88de26138a shell-xfixes-cursor: missing XFree 72f9f482d6 st-private: Fix memory leak c975740f92 st-private: Correct fix for memory leak 4e9ef93c06 Some icons randomly appear twice Not in gnome-3-0 but tested in Fedora RPM: 101a07a3d7 network: fix handling of AP flags and enhance for 802.1x c31109800b network: simplify connection sorting by using libnm-glib ae0652d13f fix initial connections to WPA[2] Enterprise APs 5090a4ccce network: request that nm-applet show the mobile broadband Tested and rereviewed fixes for minor issues: d104f9210a PopupSliderMenuItem: intercept clicks outside the slider ffd461cdb4 telepathyClient: don't update notifications for outgoing 63b1699a35 panel: Don't propagate button-release-event in _onCornerClicked() 4b3fbc4c9b network: fix modem connected state check 74a39ae57c shell-app: Fix a case where last_user_time isn't updated. 6e6b1e6052 workspace: End zooming when starting a window drag Tested and rereviewed fixes for almost unnoticeable issues: (going to merge but will feel stupid if one of these causes a regression) bafd9c777a history: Fix navigation when entering a repeat 56d584b7c6 workspace opacity is wrong after canceled drag bc2b47974d workspace: Use Main.uiGroup instead of global.stage 73cae8ce9a st-scroll-view: remove spurious assignment of uninitialized data ---- The line ---- Changes that have impact but are too big for easy re-review: (not planning to merge but feel bad about that) d0780d16224 NetworkMenu: keep wirelesss networks in predictable order 42a5531f158 network: fix a variable name 76fce94b66b BluetoothStatus: always update devices Fixes for things that don't affect users: bee37b5bc4 lookingGlass: make Esc work on any page 0d440bb0a2 StTooltip: add missing break statement #646919 environment: improve Object.toString for delegate objects #646915 panel: provide a consistent way to refer to panel items from #631576 Use upstream gettext instead the Glib one #649981 Use Shell.get_file_contents_utf8_sync over GLib.file_get_contents Changes that have little impact and I'm not comfortable with testing/review: d2a16bca10fc altTab: Fix the appSwitcher's allocation fe08edbe2bf8 altTab: fix Alt+Tab scrolling on initial display Patches/issues that need more work or research: dcd07eb23f StTextureCache: plug leak in not-found icon case 71dfab9711 altTab: remove erroneous/superflous pick 48acc41698 Don't crash when removing nameless user c4f5274d74 appMenu: Disable reactivity at the start of animation 2e02918323 WindowOverlay: Show close button after an animation a87f51487e Display dialogs on the primary monitor when no window has focus. Not eligible changes: 8ec62ce46b bluetooth: fix mis-spelling of "Set up" 986d72d9de configure: remove support for evolution-data-server 1.2 fb384fc291 shell-tp-client: enable client recovery _______________________________________________ gnome-shell-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gnome-shell-list
