On Wed, 2007-03-28 at 21:27 +0200, Alexander Larsson wrote: > On Wed, 2007-03-28 at 12:52 -0600, Hans Petter Jansson wrote:
> > I basically arrived at the value based on what would be acceptable > > fadvise() CPU overhead (<1%) for the XFS runs that were posted. > > > > Will you accept the patch if I just set DROP_CACHE_BATCH_SIZE to 20MB? > > It would preserve the lower fadvise() limit and cause cache "pollution" > > of up to 20MB during the operation. > I think its better to have two values for this. Even if we later change > the 20 meg value i think its valuable to differentiate these two > settings, as they are really two different things (one is batching to > avoid many fadvice calls, one is some attempt to guess when caches can > be safely dropped). Ok. I've attached a revised patch to the bug at: http://bugzilla.gnome.org/show_bug.cgi?id=363400 -- Hans Petter _______________________________________________ gnome-vfs-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gnome-vfs-list
