>
> The patch looks cool. This will definitely be in .77 I just have
> two remarks:
>
> [EMAIL PROTECTED] writes:
> > {
> > create_key();
> > }
> > @@ -97,18 +93,82 @@
> > Key_engraver::read_req (Key_change_req const * r)
> > {
> > key_.clear ();
> > - key_.multi_octave_b_ = r->multi_octave_b_;
> > + Scalar prop = get_property ("specialaccidentals");
> > + if (prop.length_i () > 0)
> > + {
> > + key_.multi_octave_b_ = (bool) prop;
> > + }
>
> I think this is a bug; you say
> normalkey = {
> \property Staff.specialaccidentals = 0
> }
>
> which has a length_i () >0.
No, it works correctly.
If you didn't set the property at all, then you don't go into the
if branch and multi_octave_b_ defaults to false. On the other hand,
if you explicitly set specialaccidentals to "0" or "false", then
multi_octave_b_ is explicitly set to false. Clear enough?
>
> > - if (r->multi_octave_b_)
> > - key_.set (m_l);
> > + int p;
> > + if (r->pitch_arr_.size() < 1) {
> > + r->warning(_ ("No clef name, defaults to C"));
>
>
> clef name ? (is that key name ? )
Yes of course!
[EMAIL PROTECTED] said:
>> What about dropping the octave difference C / c?
>> Is anybody using that?
>> Jan.
> I've never seen it used since I scrapped it from wtk1-fugue2
Well, I still have a number of scores written before the relative
octave was introduced and I think it's useful from time to time.
Take a look at the bass part of gallina.ly to see an example
where absolute octaves and the C/c difference is really handy.
Are you still reading? I have a couple of other bugs to report
on pl 75:
- There should be a minimum distance between staffs in a multi-staff
score. If you now have two staffs with only whole notes, then they
end up precisely edge to edge.
- The stemup/stemdown (voiceone/voicetwo) feature seized to work somewhere
between pl 69 and pl 74.
Example:
<{\voiceone e e e e}
{\voicetwo c c c c}>
/Mats
