Juergen Reuter <[EMAIL PROTECTED]> writes:
> > > -fet_beginchar("Sharp" , "1", "sharp");
> > > +fet_beginchar("Default Sharp" , "default1", "defaultsharp");
>
> I *can* leave the names intact, but I highly recommend to change them for
> backwards compatibility reasons of future lilypond versions:
... and break compatibility with previous versions in the process.
> My patch introduces a consistent naming scheme of the form 'style +
> char_mnemonic', where, in the above case, style equals "default". Leaving
> the existing names intact means that you have to set style to "", which is
> really awkward. Of course, one could introduce code that checks if style
> equals "default" and then internally patches it to be "", but that would
> be a hack.
Why is setting style to "default" less ugly than ""?
> BTW., I agree that "default" is not a proper name; maybe something like
> "contemporary" is more appropriate. Any other suggestions?
Well, in that case we should prefix alost every single feta character
we have now with `default' (or `contemporary'). I don't like that
very much.
> In other words, I just would like to submit yet another
> patch for ancient-font.ly (either as diff or as full copy) as soon as the
> rest of the two patches has made it into 1.5.x. Is that ok?
Sure, that's fine.
Jan.
--
Jan Nieuwenhuizen <[EMAIL PROTECTED]> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien | http://www.lilypond.org
_______________________________________________
Gnu-music-discuss mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/gnu-music-discuss
