Conrad Canterford writes:
> I'm wondering what the policy is with renaming subroutines.
>
> My most recent change moved stuff from the status bar to a new summary
> bar on the main window. However, the routine that refreshes this stuff
> is still called "gnc_ui_refresh_statusbar".
> For consistency and understandability, the current refresh subroutine
> should probably become "gnc_ui_refresh_summarybar" (since all its
> functionality now deals with the summary bar, not the status bar). As
> far as I'm aware, this subroutine shouldn't be called anywhere outside
> of window-main.c, so it should be safe to do so. Should I do this?
If a function's name no longer indicates what it actually does,
then it should definitely be renamed. So yes, feel free to rename
it.
> If I do this, should I leave an empty "gnc_ui_refresh_statusbar", since
> the status bar still exists and may be used for something refreshable in
> the future?
No, don't bother, it would just add clutter. We can always add it
back if we need to. Personally, though, I like the status bar to
extend the width of the window. I've come to think that having
the extra widgets tacked on the end doesn't look very good and
it often makes the status area too small to display the help
text in full.
dave
_______________________________________________
gnucash-devel mailing list
[EMAIL PROTECTED]
http://www.gnumatic.com/cgi-bin/mailman/listinfo/gnucash-devel
