On 05-11-12 14:22, Cristian Marchi wrote:
No problem!

I've tested the new addition in regards of translations and I've two problems with the strings in the viewdoc.php file:
- the string in line 118 doesn't get caught by the make pot command
- the string in line 112 is truncated in the pot file

As I see you have a better knowledge of php than me, it is very possible you can spot the problem faster than myself!

Indeed. The problem is that the T_ construct can't deal with strings that contain parameters. In that case printf should be used, much like in C. Thanks for spotting this. I have committed a fix.

Geert

Regards
Cristian

Il 05/11/2012 13:44, Geert Janssens ha scritto:
Oops. Sorry about this and thanks for correcting my mistakes.

I had doubted whether or not to cherry-pick all my commits into trunk instead of simply copying over the files. I should have gone that path, it would have preserved the newer changes in trunk.

Geert

On 05-11-12 12:48, Cristian Marchi wrote:
Author: cmarchi
Date: 2012-11-05 06:48:05 -0500 (Mon, 05 Nov 2012)
New Revision: 22524
Trac: http://svn.gnucash.org/trac/changeset/22524

Modified:
    htdocs/trunk/externals/header.phtml
Log:
Complete previous commit by adding also zh_TW language.

Modified: htdocs/trunk/externals/header.phtml
===================================================================
--- htdocs/trunk/externals/header.phtml 2012-11-05 11:44:55 UTC (rev 22523) +++ htdocs/trunk/externals/header.phtml 2012-11-05 11:48:05 UTC (rev 22524)
@@ -125,7 +125,8 @@
<!--| <a class="nav" href="<?= make_lang_href($current_page, $get_parms, "nb_NO"); ?>">Norsk Bokm&aring;l</a>--> <!-- | <a class="nav" href="<?= make_lang_href($current_page, $get_parms, "pl_PL"); ?>">Polska</a> --> <!--| <a class="nav" href="<?= make_lang_href($current_page, $get_parms, "pt_PT"); ?>">Portugu&ecirc;s</a>--> -| <a class="nav" href="<?= make_lang_href($current_page, $get_parms, "zh_CN"); ?>">中文</a> +| <a class="nav" href="<?= make_lang_href($current_page, $get_parms, "zh_CN"); ?>">简体中文</a> +| <a class="nav" href="<?= make_lang_href($current_page, $get_parms, "zh_TW"); ?>">繁體中文</a>
  </span>
  <span id="location">&nbsp; <!-- <?= _("Continent"); ?>:
   (<a class="nav" href="http://www.gnucash.org/";>US</a>)

_______________________________________________
gnucash-changes mailing list
[email protected]
https://lists.gnucash.org/mailman/listinfo/gnucash-changes

_______________________________________________
gnucash-devel mailing list
[email protected]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


_______________________________________________
gnucash-devel mailing list
[email protected]
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Reply via email to