Geert, Just an observation, when I do an import and select the date column first with an invalid default format, the view goes red and the error message tells me what is wrong. At the same time I ended up with 20 WARN messages, one for each line in the trace file. I was wondering if gnc_dmy2timespec_neutral should have an extra parameter to suppress the WARN messages in this use. I can not really decide whether this is worthwhile or not.
Bob On 20 February 2017 at 19:54, Geert Janssens <geert.gnuc...@kobaltwit.be> wrote: > Op vrijdag 17 februari 2017 22:09:00 CET schreef Geert Janssens: > > Op zondag 12 februari 2017 11:50:35 CET schreef Robert Fewell: > > > Geert, > > > > > > OK I got your latest changes and all built and ran OK. Needed to reread > > > your comment about dates as I could not see what gnc_numeric had to do > > > with > > > it !! > > > > Well, they don't. I'm mixing two issues in one... > > > > > Some changes I think required. > > > 1. The initial text on the assistant page. > > > > Indeed. Things have changed since you last updated this text. > > > > > 2. If you have selected an account in the combo and then choose to > select > > > a > > > column instead, the combo should return back to blank > > > > > > as it does in the opposite direction. > > > > Good catch. At some point it did behave like that. It seems one of my > more > > recent refactorings broke this. > > > > > 3.If you open a csv with a semicolon separator, tick the semicolon > > > setting, > > > then the fixed-width setting and now back to separators the preview > does > > > not reformat with the semicolon separator. > > > Not sure if it should or the separator choice should revert back to > > > default. > > Another good catch. I think it should reformat using the semicolon > > separator. I'll add this to my list of things to fix. > > > > > > Meanwhile I have also managed to fix the multi-byte splitting issue in > the > > fixed width tokenizer. I can't produce invalid characters any more by > > splitting in the middle of a multi-byte character. > > > > And the newlines are being stripped as well. > > > > Left to do are the points you bring up above, catching date parsing > errors > > and using GncNumeric instead of gnc_numeric. > > > All the points left to do have been dealt with. > > - The intro text on the start page has been updated > - base account is reset when an account is set in the preview data > - separator settings are restored when switching back from fw to separated > - date parsing errors are properly caught > - I have run tests with GncNumeric and provided some feedback on John's > branch > thanks to this > > While there are still some improvements possible I have decided it's time > to > merge this work into master. And that's what I've just done. This work > moves > quite some files around so if you pull in these changes you may need to > clean > your workspace and build environment and rerun autogen.sh/configure. I > believe > cmake properly detects the changes and will rerun automatically. > > To all: please do test and report any issues you find! > > Geert > _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
