-----BEGIN PGP SIGNED MESSAGE----- On Montag, 29. Juli 2002 23:00, Benoit Gr�goire wrote: > On Mon 29 July 2002 11:29, Christian Stimming wrote: > > Can we extend that function so that > > it takes two arguments: one online_id string that gets stored but not > > shown, and another account_name string that gets shown to the user? That > > would make this dialog really much more helpful. > > Ok, good idea. I'll have patches by tomorrow. The string shown at the top > of the dialog will now be passed to the function. However I somewhat > dislike the ID not being shown at all (if only for debugging reasons). > Perhaps in parentheses at the end of the string?
Hm... of course debugging is another issue. But in this question I somewhat distinguished the "machine-readable" account id versus the "human-readable" account id. To identify an account for a human, I would write "Bank code: 123 455 78, Country: Utopia, Account code: 26 984 09 27". For a machine, I would of course write something different... So my point was to have one argument for the machine-readable account id which also gets stored in the kvp frame, and having the other argument be the human-readable account identification. > > Besides, Benoit: you introduced the kvp-key "online_id" in > > gnc-generic-import.c, but IIRC every coder is supposed to document such > > a key in the file src/engine/kvp_doc.txt. Should I add that there, or > > are you going to do that? Also, in the other kvp keys for whatever > > reason people prefer to use the minus sign instead of underscores. Do > > you think it is still possible to switch to the key string "online-id"? > > I think that would fit in much nicer. Thanks for all your code, anyway. > > I didn't even know this file existed. Could you add it there? It will be > much more convenient since you have CVS access. You can also change the > name of the frame itself if you want, it is still (and always will be) > trivial. Just change the frame name inside the setter and getter functions > in gnc-generic-import.c: > gchar * gnc_import_get_acc_online_id(Account * account) > gchar * gnc_import_set_acc_online_id(Account * account) Sure, I can do that tomorrow. Christian -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iQCVAwUBPUWyuWXAi+BfhivFAQEjPQQAr0F1/wC3629kipGpHNUhiTcxVnledfvt gHO1z0/SX2SvGASWDXIPEp6B1bDFNHyYVsdlrvLuFXAnUIWhpQH4YwivqT1Ds0YM a6KQQzSJrhMt1xdCDHNMnxj/vIBcVqkeYCoI9oU8M+XguwsECbnpRSOviJp75iEN h5km50boEQ8= =ZEin -----END PGP SIGNATURE----- _______________________________________________ gnucash-devel mailing list [EMAIL PROTECTED] http://www.gnucash.org/cgi-bin/mailman/listinfo/gnucash-devel
