On Thu, 29 Sep 2005, Teun Burgers wrote: > Arend wrote: > > > rotation code > > > > The cost of this code is small, but I think its benefit is almost > > non-existant. > > As contributor of this code I vote to keep it :) > > It is still functional and not too difficult to use: > > e.g. for any test suite: > make reading GG_OPTIONS="--orientation 1" > > or using a predefined target: > make owl_rotall > > The reading tests are currently all invariant under reorientation, > so that is good to know. Past invariances have led to uncovery of bugs > in the reading code. Since the cost and maintenance is little I suggest to > keep it.
I understand its purpose, but: 1. Since I have joined GNU Go 4 years ago, there has never been a bug discovered by this. 2. There are so many expected rotational dependencies all around the code, that I don't think any developer would track down a rotational depency of a test case and see whether it really is a bug (since 99% of the time it won't be). 3. This code does not come for free, as it obfuscates rather central code. (Try 'grep orientation' or 'grep rot' in interface/.) 4. This functionality is easily implemented with external scripts. (I have a script to convert .sgf-files to a GTP stream that could easiliy be adopted to convert the loadsgf commands in the .tst-files on the fly to GTP stream that already includes the orientation.) Arend _______________________________________________ gnugo-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnugo-devel
