Hi all :)
Here are some trivial patches:
01 fixes typo.
03 removes unnecessary if() and else, as both branches do the same thing.
02,04,05 fix incorrect handling of unsigned values.
-- Igor
Index: src/dns/gnunet-service-dns.c
===================================================================
--- src/dns/gnunet-service-dns.c (revision 19758)
+++ src/dns/gnunet-service-dns.c (working copy)
@@ -1324,7 +1324,7 @@
srca4->sin_port = udp->source_port;
dsta4->sin_port = udp->destination_port;
#if HAVE_SOCKADDR_IN_SIN_LEN
- srca4->sin_len = sizeof (struct sockaddr_in))
+ srca4->sin_len = sizeof (struct sockaddr_in);
dsta4->sin_len = sizeof (struct sockaddr_in);
#endif
}
Index: src/transport/gnunet-helper-transport-wlan.c
===================================================================
--- src/transport/gnunet-helper-transport-wlan.c (revision 19758)
+++ src/transport/gnunet-helper-transport-wlan.c (working copy)
@@ -1053,9 +1053,6 @@
{
unsigned long crc;
- if (0 > len)
- return 0;
-
crc = calc_crc_osdep (buf, len);
buf += len;
return (((crc) & 0xFF) == buf[0] && ((crc >> 8) & 0xFF) == buf[1] &&
Index: src/transport/gnunet-service-transport_clients.c
===================================================================
--- src/transport/gnunet-service-transport_clients.c (revision 19758)
+++ src/transport/gnunet-service-transport_clients.c (working copy)
@@ -482,12 +482,8 @@
tc = lookup_client (client);
#if DEBUG_TRANSPORT
- if (tc != NULL)
- GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
- "Client %X sent START\n", tc);
- else
- GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
- "Client %X sent START\n", tc);
+ GNUNET_log (GNUNET_ERROR_TYPE_DEBUG | GNUNET_ERROR_TYPE_BULK,
+ "Client %X sent START\n", tc);
#endif
if (tc != NULL)
{
Index: src/fs/fs_search.c
===================================================================
--- src/fs/fs_search.c (revision 19758)
+++ src/fs/fs_search.c (working copy)
@@ -421,7 +421,7 @@
GNUNET_CONTAINER_meta_data_merge (sr->meta, meta);
}
koff = ent - sc->requests;
- GNUNET_assert ( (koff >= 0) && (koff < sc->uri->data.ksk.keywordCount));
+ GNUNET_assert ( (ent >= sc->requests) && (koff < sc->uri->data.ksk.keywordCount));
sr->keyword_bitmap[koff / 8] |= (1 << (koff % 8));
/* check if mandatory satisfied */
if (ent->mandatory)
Index: src/fs/fs_uri.c
===================================================================
--- src/fs/fs_uri.c (revision 19758)
+++ src/fs/fs_uri.c (working copy)
@@ -1404,8 +1404,12 @@
if (uri->type == ksk)
{
- for (i = uri->data.ksk.keywordCount - 1; i >= 0; i--)
+ for (i = uri->data.ksk.keywordCount - 1; ; i--)
+ {
GNUNET_assert (uri->data.ksk.keywords[i] != NULL);
+ if (i == 0)
+ break;
+ }
}
#endif
return uri->type == ksk;
_______________________________________________
GNUnet-developers mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/gnunet-developers
