Author: fredkiefer
Date: Sun Apr 16 13:54:21 2017
New Revision: 40484
URL: http://svn.gna.org/viewcvs/gnustep?rev=40484&view=rev
Log:
Fix some clang static analyser warnings reported by
Sebastian Reitenbach <sebas...@l00-bugdead-prods.de>.
Modified:
libs/gui/trunk/ChangeLog
libs/gui/trunk/Model/IMLoading.m
libs/gui/trunk/Source/GSTextStorage.m
libs/gui/trunk/Source/GSToolbarView.m
libs/gui/trunk/Source/NSLayoutManager.m
libs/gui/trunk/Source/NSTableView.m
Modified: libs/gui/trunk/ChangeLog
URL:
http://svn.gna.org/viewcvs/gnustep/libs/gui/trunk/ChangeLog?rev=40484&r1=40483&r2=40484&view=diff
==============================================================================
--- libs/gui/trunk/ChangeLog (original)
+++ libs/gui/trunk/ChangeLog Sun Apr 16 13:54:21 2017
@@ -1,3 +1,17 @@
+2017-04-16 Fred Kiefer <fredkie...@gmx.de>
+
+ * Model/IMLoading.m
+ * Source/GSTextStorage.m
+ * Source/GSToolbarView.m
+ * Source/NSLayoutManager.m
+ * Source/NSTableView.m
+ Fix some clang static analyser warnings reported by
+ Sebastian Reitenbach <sebas...@l00-bugdead-prods.de>.
+
+2017-04-06 Ivan Vucica <i...@vucica.net>
+
+ * Releasing 0.25.1.
+
2017-04-05 Fred Kiefer <fredkie...@gmx.de>
* Headers/Additions/GNUstepGUI/GSXibKeyedUnarchiver.h: Moved from
Source.
@@ -5,10 +19,6 @@
* Source/GSXibLoader.m,
* Source/GSXibKeyedUnarchiver.m,
* Source/GNUmakefile: Use and install moved header file.
-
-2017-04-04 Ivan Vucica <i...@vucica.net>
-
- * Releasing 0.25.1.
2017-04-01 Fred Kiefer <fredkie...@gmx.de>
Modified: libs/gui/trunk/Model/IMLoading.m
URL:
http://svn.gna.org/viewcvs/gnustep/libs/gui/trunk/Model/IMLoading.m?rev=40484&r1=40483&r2=40484&view=diff
==============================================================================
--- libs/gui/trunk/Model/IMLoading.m (original)
+++ libs/gui/trunk/Model/IMLoading.m Sun Apr 16 13:54:21 2017
@@ -43,7 +43,6 @@
void __dummy_IMLoading_functionForLinking()
{
- __dummy_IMLoading_functionForLinking();
}
@implementation GMModel
@@ -207,18 +206,3 @@
}
@end /* GMModel */
-
-
-#if GNU_RUNTIME
-#include "IMConnectors.h"
-
-__attribute__((unused))
-static void __dummyFunctionForLinking (void)
-{
- [IMCustomObject new];
- [IMConnector new];
-
- __dummyFunctionForLinking();
-}
-
-#endif
Modified: libs/gui/trunk/Source/GSTextStorage.m
URL:
http://svn.gna.org/viewcvs/gnustep/libs/gui/trunk/Source/GSTextStorage.m?rev=40484&r1=40483&r2=40484&view=diff
==============================================================================
--- libs/gui/trunk/Source/GSTextStorage.m (original)
+++ libs/gui/trunk/Source/GSTextStorage.m Sun Apr 16 13:54:21 2017
@@ -89,7 +89,7 @@
static NSDictionary *blank;
static NSLock *attrLock = nil;
-static __strong GSIMapTable_t attrMap;
+static GSIMapTable_t attrMap;
static SEL lockSel;
static SEL unlockSel;
static IMP lockImp;
Modified: libs/gui/trunk/Source/GSToolbarView.m
URL:
http://svn.gna.org/viewcvs/gnustep/libs/gui/trunk/Source/GSToolbarView.m?rev=40484&r1=40483&r2=40484&view=diff
==============================================================================
--- libs/gui/trunk/Source/GSToolbarView.m (original)
+++ libs/gui/trunk/Source/GSToolbarView.m Sun Apr 16 13:54:21 2017
@@ -63,9 +63,6 @@
static const int ClippedItemsViewWidth = 28;
-// Internal
-static const int current_version = 1;
-
static NSUInteger draggedItemIndex = NSNotFound;
/*
@@ -270,12 +267,12 @@
if (draggedItemIndex == NSNotFound)
{
//simply locate the nearest location between existing items
- for (index=0; index < [visibleBackViews count]; index++)
+ for (index = 0; index < [visibleBackViews count]; index++)
{
NSRect itemRect = [[visibleBackViews objectAtIndex:index] frame];
if (location.x < (itemRect.origin.x + (itemRect.size.width/2)))
{
- NSLog(@"AT location %d", index);
+ NSLog(@"At location %lu", (unsigned long)index);
return index;
}
}
Modified: libs/gui/trunk/Source/NSLayoutManager.m
URL:
http://svn.gna.org/viewcvs/gnustep/libs/gui/trunk/Source/NSLayoutManager.m?rev=40484&r1=40483&r2=40484&view=diff
==============================================================================
--- libs/gui/trunk/Source/NSLayoutManager.m (original)
+++ libs/gui/trunk/Source/NSLayoutManager.m Sun Apr 16 13:54:21 2017
@@ -1815,7 +1815,7 @@
unsigned int char_index =
[self characterRangeForGlyphRange: NSMakeRange(g, 1)
actualGlyphRange: NULL].location;
- NSObject<NSTextAttachmentCell> *cell = [[_textStorage
attribute: NSAttachmentAttributeName
+ id<NSTextAttachmentCell> cell = [[_textStorage attribute:
NSAttachmentAttributeName
atIndex: char_index
effectiveRange: NULL] attachmentCell];
NSRect cellFrame;
Modified: libs/gui/trunk/Source/NSTableView.m
URL:
http://svn.gna.org/viewcvs/gnustep/libs/gui/trunk/Source/NSTableView.m?rev=40484&r1=40483&r2=40484&view=diff
==============================================================================
--- libs/gui/trunk/Source/NSTableView.m (original)
+++ libs/gui/trunk/Source/NSTableView.m Sun Apr 16 13:54:21 2017
@@ -6031,7 +6031,7 @@
{
NSArray *array;
NSNumber *width, *identNum;
- NSObject *ident;
+ id ident;
width = [NSNumber numberWithInt: [column width]];
ident = [column identifier];
_______________________________________________
Gnustep-cvs mailing list
Gnustep-cvs@gna.org
https://mail.gna.org/listinfo/gnustep-cvs
