I would prefer __MINGW32__ everywhere, just in case somehow, somewhere, preface.h is not included for whatever reason.

I understand the desire for consistancy. And I found one case where the wrong side of the #if was being compiled. (Although it wasn't actually one that you changed on 2005-10-09. ;)

----- Original Message ----- From: "Richard Frith-Macdonald" <[EMAIL PROTECTED]>
To: <gnustep-dev@gnu.org>
Sent: Tuesday, October 11, 2005 1:50 PM
Subject: Re: use of __MINGW32__ in gnustep-base


On 2005-10-11 18:28:23 +0000 Jeremy Bettis <[EMAIL PROTECTED]> wrote:

I refer to this ChangeLog:
2005-10-09  Richard Frith-Macdonald <[EMAIL PROTECTED]>
Be consistent in usage of __WIN32__ and __MINGW__


Um.... There is no preprocessor define for __MINGW__,

Actually, it's defined in preface.h (and has been for ages).

so now that code that used to compile does not. Try putting it back to __MINGW32__

It was inconsistent (using both defines in diufferent places).

Using one define throughout compiled for me ...
but I have no problem with using __MINGW32__ as the standard if you prefer.



_______________________________________________
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev




_______________________________________________
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev

Reply via email to