I just found a critical bug that needs to be fixed before we do a new gui release. Not sure if this warning is needed, but sometimes Adam is really quick with new releases :-)
The problem gets triggered by a patch I recently made to NSCell. Now the control sendAction:to: methods gets called even when there is no action set. This was needed for KVB compatibility with Apple and in itself this is not the problem it just reveals a longer standing issue. In NSToolbar we now get the following loop: #6 0xb7b975f7 in -[NSCell performClickWithFrame:inView:] ( self=0x8886070, _cmd=0xb7daa9a0, cellFrame= {origin = {x = 0, y = 0}, size = {width = 61, height = 61}}, controlView=0x88854e8) at NSCell.m:1399 #7 0xb7b91553 in -[NSButtonCell performClickWithFrame:inView:] ( self=0x8886070, _cmd=0xb7dbca00, cellFrame= {origin = {x = 0, y = 0}, size = {width = 61, height = 61}}, controlView=0x88854e8) at NSButtonCell.m:1486 #8 0xb7bc179a in -[NSControl performClick:] (self=0x88854e8, _cmd=0xb7e25240, sender=0x8593da8) at NSControl.m:811 #9 0xb7cc7dc5 in -[NSToolbarItem _setSelected:] (self=0x8593da8, _cmd=0xb7e5c438, selected=1 '\001') at NSToolbarItem.m:1471 #10 0xb7d620a9 in -[GSToolbar setSelectedItemIdentifier:] ( self=0x8881930, _cmd=0xb7e24f98, itemIdentifier=0xb7f59a58) at GSToolbar.m:845 #11 0xb7cc2fdd in -[GSToolbarButton sendAction:to:] (self=0x88854e8, _cmd=0xb7daea20, action=0x0, target=0x85dfb40) at NSToolbarItem.m:363 #12 0xb7b97719 in -[NSCell performClickWithFrame:inView:] ( self=0x8886070, _cmd=0xb7daa9a0, cellFrame= {origin = {x = 0, y = 0}, size = {width = 61, height = 61}}, controlView=0x88854e8) at NSCell.m:1407 #13 0xb7b91553 in -[NSButtonCell performClickWithFrame:inView:] ( self=0x8886070, _cmd=0xb7dbca00, cellFrame= {origin = {x = 0, y = 0}, size = {width = 61, height = 61}}, This didn't happen before as most toolbar items don't have an action set, so this path wasn't reached. What wee need to do now is to break this loop. I suspect that we should not be calling performClick: in the _setSelected: method on NSToolbarItem, but then I am not familiar with that code and don't know where the performClick: call really belongs. Is there anybody out there with more knowledge on NSToolbar willing to help? _______________________________________________ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev