Ugh, r34614 introduced more bugs itself (resizing the panes in Grr can make the table headers change size). I should know this would happen if I tried to change things during a code freeze...
Fred, do you think we should just ship the release with copy-on-scroll disabled? That would fix the flickering in FisicaLab reported by German, and the blurring I reported here in zoomed TextEdit. We could turn it back on after the release and try to fix those bugs. Eric On 2012-01-24, at 11:05 AM, Eric Wasylishen wrote: > I investigated this and committed a fix for scrolling in a zoomed TextEdit > document yesterday because the fix was quite simple (r34614). > > On 2012-01-23, at 4:05 PM, Eric Wasylishen wrote: > >> I just found a bug caused by re-enabling copy-on-scroll. >> >> Open TextEdit (https://github.com/ericwa/TextEdit), open a document or paste >> in some text, Choose "Format->Wrap to Page", set the zoom to 150%, and >> scroll horizontally, slowly. You'll see horizontal blurring. Seems that the >> regions being copied aren't pixel-aligned. >> >> Should we just disable copy-on-scroll for this release? Ship with this bug? >> Try using -centerScanRect in >> -[NSView scrollRect: (NSRect)aRect by: (NSSize)delta]? I just fear trying to >> fix it now will create more bugs at the last minute... >> >> Eric >> >> On 2012-01-20, at 11:54 PM, Eric Wasylishen wrote: >> >>> Hi, >>> This patch reverts part of r32955 which I committed last april but I now >>> see was a mistake, and I just discovered is breaking the copy-on-scroll >>> behaviour of NSClipView - we end up always redrawing the entire visible >>> portion of the document view right now. >>> >>> In r32955 I added [self setNeedsDisplay: YES] calls to -[NSView >>> setBounds:], -setBoundsOrigin:, and -setBoundsSize:, even though these are >>> documented explicitly as not marking the view for needing display. >>> (With r32955 I was trying to fix a bug in TextEdit, which calls >>> setBoundsSize: on NSClipView when you change the page zoom, and expects the >>> view to mark itself as needing display. This is actually a bug in TextEdit >>> - it should mark the clip view as needing redisplay itself.) >>> >>> -Eric >>> >>> <NSViewBoundsRemoveSetNeedsDisplay.diff> >> >
_______________________________________________ Gnustep-dev mailing list Gnustep-dev@gnu.org https://lists.gnu.org/mailman/listinfo/gnustep-dev
