On Mon, Apr 3, 2017 at 8:43 AM, Wolfgang Lux <wolfgang....@gmail.com> wrote:

>
> > Am 02.04.2017 um 18:19 schrieb Ivan Vučica <i...@vucica.net>:
> > Looks like sysconfdir is not used here. And in fact, GNUstep.conf ends
> up in /GNUstep/etc/GNUstep/GNUstep.conf, where it presumably won't be
> found by things trying to find where GNUstep is installed.
>
> You could of course use the --with-config-file option to install the
> config file to any path of your likening, including 
> --with-config-file=/etc/GNUstep/GNUstep.conf.
> :-)
>

Which I did mention later, however, that doesn't mean sysconfdir should be
present but go unused, right? :)


>
> > I'd like to submit this:
> >
> > Index: configure.ac
> > ===================================================================
> > --- configure.ac        (revision 40432)
> > +++ configure.ac        (working copy)
> > @@ -573,7 +573,7 @@
> >     Example: --with-config-file=/usr/GNUstep/GNUstep.conf
> >     By default, if this option is not specified, the config file is
> >     /etc/GNUstep/GNUstep.conf if the prefix is /, /usr or /usr/GNUstep
> > -   and $prefix/etc/GNUstep/GNUstep.conf otherwise.  On Apple, it is
> > +   and $sysconfdir/GNUstep/GNUstep.conf otherwise.  On Apple, it is
> >     always /Library/GNUstep/GNUstep.conf regardless of prefix.
> >  ],
> >    GNUSTEP_CONFIG_FILE="$withval",)
> > @@ -584,7 +584,7 @@
> >            x)             GNUSTEP_CONFIG_FILE=/etc/
> GNUstep/GNUstep.conf;;
> >            x/usr)         GNUSTEP_CONFIG_FILE=/etc/
> GNUstep/GNUstep.conf;;
> >            x/usr/GNUstep) GNUSTEP_CONFIG_FILE=/etc/
> GNUstep/GNUstep.conf;;
> > -          *)             GNUSTEP_CONFIG_FILE="$GNUSTEP_
> PREFIX/etc/GNUstep/GNUstep.conf";;
> > +          *)             GNUSTEP_CONFIG_FILE="$
> sysconfdir/GNUstep/GNUstep.conf";;
> >          esac ;;
> >    esac
> >  fi
>
> I like the idea of using $sysconfdir, but I'd prefer going a step further
> and stripping the whole case expression altogether and just always use
> GNUSTEP_CONFIG_FILE="$sysconfdir/GNUstep/GNUstep.conf" (on non-Darwin
> systems, that is).
>

Yes, that's the behavior we get now because default $sysconfdir value seems
to be just /etc, not PREFIX/etc as is documented. But, not taking PREFIX
into account might break packagers.

That's why I didn't submit this yet. Not sure what to do.
_______________________________________________
Gnustep-dev mailing list
Gnustep-dev@gnu.org
https://lists.gnu.org/mailman/listinfo/gnustep-dev

Reply via email to