Hi,

In Grr there is this code:

    wsAndTagClosing = [NSMutableCharacterSet
characterSetWithCharactersInString: @"/>"];

Clang warns me with:

NSString+TolerantHTML.m:109:21: warning: incompatible pointer types
assigning to 'NSMutableCharacterSet *' from 'NSCharacterSet *'
[-Wincompatible-pointer-types]
  109 |     wsAndTagClosing = [NSMutableCharacterSet
characterSetWithCharactersInString: @"/>"];

GCC gives a more generic issue about "distinct objective C type".

Now, characterSetWithCharactersInString: is a class method of
NSCharacterSet:

https://www.gnustep.org/resources/documentation/Developer/Base/Reference/NSCharacterSet.html#method$NSCharacterSet+characterSetWithCharactersInString$

and NSMutableCharacterSet is a subclass of NSCharacterSet

Shouldn't thus the method called on the subclass still return a valid
subclass and not the superclass?

Could it be a header issue? we define it as:
+ (NSCharacterSet*) characterSetWithCharactersInString: (NSString*)aString;

maybe it should return instancetype?

Just wondering & asking.

Riccardo


Reply via email to