Hi,

I'n upgrading our gocd from 18.10.0 to 18.12.0.
On the old version I'm able to create a config repo (using the api 
/admin/config_repos) but with the new version I'm getting the following 
error:

Client side:

Received HTTP Status '500 Internal Server Error': {
      "message": "Save failed. An error occurred while saving the package 
config. Please check the logs for more
      information."
}


Server side:

                                         
2019-01-10 23:18:00,090 ERROR [qtp815992954-24] PackageDefinitionService:69 
- failed to save : Attribute 'materialName' is not allowed to appear in 
element 'git'.                                                              
            
java.lang.RuntimeException: failed to save : Attribute 'materialName' is 
not allowed to appear in element 'git'.
    at 
com.thoughtworks.go.config.GoFileConfigDataSource.trySavingEntity(GoFileConfigDataSource.java:319)
    at 
com.thoughtworks.go.config.GoFileConfigDataSource.writeEntityWithLock(GoFileConfigDataSource.java:263)
    at 
com.thoughtworks.go.config.CachedGoConfig.writeEntityWithLock(CachedGoConfig.java:157)
    at 
com.thoughtworks.go.config.GoConfigDao.updateConfig(GoConfigDao.java:96)
    at 
com.thoughtworks.go.server.service.GoConfigService.updateConfig(GoConfigService.java:292)
    at 
com.thoughtworks.go.server.service.ConfigRepoService.update(ConfigRepoService.java:63)
    at 
com.thoughtworks.go.server.service.ConfigRepoService.createConfigRepo(ConfigRepoService.java:91)
    at 
com.thoughtworks.go.apiv1.configrepos.ConfigReposControllerV1.createRepo(ConfigReposControllerV1.java:118)
    at spark.RouteImpl$1.handle(RouteImpl.java:72)
    at spark.http.matching.Routes.execute(Routes.java:61)
    at spark.http.matching.MatcherFilter.doFilter(MatcherFilter.java:130)
    at spark.servlet.SparkFilter.doFilter(SparkFilter.java:173)
    at 
com.thoughtworks.go.spark.SparkPreFilter.doFilter(SparkPreFilter.java:53)
    at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
    at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
    at 
org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:420)
    at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:566)
    at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:190)
    at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1595)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:188)
    at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1253)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:168)
    at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:473)
    at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1564)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:166)
    at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1155)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
    at org.eclipse.jetty.server.Dispatcher.forward(Dispatcher.java:203)
    at org.eclipse.jetty.server.Dispatcher.forward(Dispatcher.java:73)
    at 
org.tuckey.web.filters.urlrewrite.NormalRewrittenUrl.doRewrite(NormalRewrittenUrl.java:213)
    at 
org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:171)
    at 
org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:145)
    at 
org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:92)
    at 
org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:381)
    at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317)
    at 
com.thoughtworks.go.server.web.FlashLoadingFilter.doFilterInternal(FlashLoadingFilter.java:39)
    at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:208)
    at 
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:185)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317)
    at 
com.thoughtworks.go.server.newsecurity.filters.DenyIfRefererIsNotFilesFilter.doFilterInternal(DenyIfRefererIsNotFilesFilter.java:53)
  
                                                                            
                   
    at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:214)
    at 
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:185)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317)
    at 
com.thoughtworks.go.server.newsecurity.filters.VerifyAuthorityFilter.doFilterInternal(VerifyAuthorityFilter.java:58)
  
                                                                            
                                   
    at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:214)
    at 
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:185)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:208)
    at 
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:185)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317)
    at 
com.thoughtworks.go.server.newsecurity.filters.AlwaysCreateSessionFilter.doFilterInternal(AlwaysCreateSessionFilter.java:41)
    at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
com.thoughtworks.go.server.newsecurity.filters.AbstractSessionReduceIdleTimeoutFilter.doFilterInternal(AbstractSessionReduceIdleTimeoutFilter.java:45)
    at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:214)
    at 
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:185)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
com.thoughtworks.go.server.newsecurity.filters.ModeAwareFilter.doFilter(ModeAwareFilter.java:80)
    at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
    at 
org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:214)
    at 
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:177)
    at 
com.thoughtworks.go.server.newsecurity.filterchains.MainFilterChain.doFilter(MainFilterChain.java:76)
    at 
org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:347)
    at 
org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:263)
    at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
    at 
com.thoughtworks.go.server.web.BackupFilter.doFilter(BackupFilter.java:81)
    at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
    at 
com.thoughtworks.go.server.web.DefaultHeadersFilter.doFilter(DefaultHeadersFilter.java:50)
    at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1629)
    at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
    at 
org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:527)
    at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
    at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:190)
    at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1595)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:188)
    at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1253)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:168)
    at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:473)
    at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1564)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:166)
    at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1155)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
    at 
org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:219)
    at 
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:126)
    at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
    at org.eclipse.jetty.server.Server.handle(Server.java:530)
    at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:347)
    at 
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:256)
    at 
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:279)
    at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:102)
    at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:124)
    at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:247)
    at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.produce(EatWhatYouKill.java:140)
    at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
    at 
org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:382)
    at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:708)
    at 
org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:626)
    at java.lang.Thread.run(Thread.java:748)


Is that a new feature or is it a regression?

Looks to me that it would need at least to be specified in the doc if it's 
a feature. I can do the PR for that, I just need to make sure it's not a 
bug first.

Thanks
Joseph

-- 
You received this message because you are subscribed to the Google Groups 
"go-cd" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to