Many thanks Aravind. Yes, I'll open an issue on github since I'm still getting the same result (no dialog) with a bare ubuntu bionic, installed gocd server and agent 20.1.0 and the same pipeline as yours.
On Thu, 19 Mar 2020 at 06:29, Aravind SV <[email protected]> wrote: > Hello, > > I tried with a simple pipeline and in a GoCD server (20.2.0) without any > authentication and it does show the prompt, as it should. On the pipeline > history page, it should show a prompt and on the stage details page, it > doesn't. > > Here's the config I used: > > <pipeline name="p1"> > <materials> > <git url="/tmp/test.git" /> > </materials> > <stage name="s1"> > <jobs> > <job name="j1"> > <tasks> > <exec command="ls" /> > </tasks> > </job> > </jobs> > </stage> > <stage name="s2"> > <approval type="manual" /> > <jobs> > <job name="j1"> > <tasks> > <exec command="ls" /> > </tasks> > </job> > </jobs> > </stage> > </pipeline> > > > [image: 2020_03_18_17-21-59.png] > > > It might be easier to open an issue on GitHub, with more information about > the config you're using and the behaviour you're seeing. > > Cheers, > Aravind > > > > On Tue, Mar 17, 2020 at 9:47 PM Bopolissimus X Platypus < > [email protected]> wrote: > >> Hi all, >> >> GoCD version: >> 20.1.0 (11114-f2c1771e333ea92dae82cd78d2efa1310c1086f0). >> >> I'm aware of a go-cd installation where, with at least one pipeline >> (not all have this behavior), one of the manual stages, when >> triggered, pops up a confirmation dialog box that says "Do you want to >> run the stage 'StageDeploy'?". The dialog has two buttons "No" and >> "Yes". Most other manual stages don't have this, they just go ahead >> and run. >> >> I've attached screen captures of the relevant configuration. >> stage-deploy.png is the stage configuration, confirm-dialog is the >> dialog itself, once the ">|" button (between the preceding stage and >> the manual stage deploy) is pressed. >> >> When I set up a local go-cd installation for testing things out, I >> *don't* get this dialog. This is with a very simple two-stage >> pipeline where the second pipeline is Manual (just as in the >> stage-deploy screen shot). >> >> A grep of the source code tag 21.1.0 has this >> >> "Do you want to run the stage '${stage.stageName()}'?" >> >> in >> server/src/main/webapp/WEB-INF/rails/webpack/views/pages/pipeline_activity.tsx >> (in runStage(stage: Stage) at line 104. >> >> So it looks like there's *something* that can trigger the dialog (the >> screenshots show the dialog being shown, the source shows what might >> be showing that, now I just need to find *what* triggers that dialog. >> >> Can anyone point out (in the documentation, or by description) how to >> configure a stage so that that confirmation dialog pops up? >> >> In my test setup, I've only tested: >> >> A -- no authentication >> B -- file authentication with only admin in there >> >> I mention authentication above since the other system that does have >> this confirmation pop-up (which I can't inspect, I only have the >> screenshots) but also a more complex authentication and authorization >> setup. >> >> possibly related (esp 4064) but I don't see any of them showing a >> specific solution.: >> >> * https://github.com/gocd/gocd/issues/4064 >> * >> https://groups.google.com/forum/#!msg/go-cd/KgsOGTPGqpM/UsR0HvfH9UkJ;context-place=forum/go-cd >> * https://github.com/gocd/gocd/issues/50 >> * https://github.com/gocd/gocd/issues/4037 >> >> Many thanks for any pointers. >> >> Gerald Quimpo >> >> -- >> You received this message because you are subscribed to the Google Groups >> "go-cd" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/go-cd/CAHJ76tdM-LNmCyQZpz8LpxgEjAd86L_xvGaJBSfv%3DfVXkxG6MQ%40mail.gmail.com >> . >> > -- > You received this message because you are subscribed to the Google Groups > "go-cd" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/go-cd/CACxychGQ5%3DtNk8y-YefQ8QMy5srvCm9yzBqgSrX9KwwFr7vOKw%40mail.gmail.com > <https://groups.google.com/d/msgid/go-cd/CACxychGQ5%3DtNk8y-YefQ8QMy5srvCm9yzBqgSrX9KwwFr7vOKw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Gerald Timothy Quimpo bopolissimus_at_gmail.com http://bopolissimus.*b*l*o*g*s*p*o*t*.com "(Postgresql) Cursors are biased towards fast-start plans on the theory that you may not be intending to fetch the whole result. Queries with ORDER BY and/or LIMIT are particularly likely to see plan changes as a consequence of that." -- You received this message because you are subscribed to the Google Groups "go-cd" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/go-cd/CAHJ76tc6XsTaUMBbkC_627GOrvaiQ3gmjY-yih%2BL0OLSMe2LKQ%40mail.gmail.com.
