Shouldn't we have two variables, like $goboPrefix _and_ $goboCrossPrefix?
Its look like to me we are at this moment using a same variable for
two different purposes, and they conflict sometimes (like in the
report made by Dan).
Having these two variables available, we could probably use something
like $goboPrefix/$goboCrossPrefix/<path> in many places, instead of
having to do testings like that one at the commit. Maybe
$goboCrossCompiling could be replaced by the new, more informative,
variable.

Lucas is probably the right person to tell if this is a good idea ;)

And this would also enable one to do cross compile in Rootless environments :)
(At his own risk, of course.)

On 9/9/06, Lucas C. Villa Real <[EMAIL PROTECTED]> wrote:
> CVSROOT:        /sources/goboscripts
> Module name:    tools
> Changes by:     Lucas C. Villa Real <lucasvr>   06/09/09 05:25:34
>
> Modified files:
>         Compile/bin    : GetRecipe
>
> Log message:
>         Fixed bug introduced in Rootless with unset. Only unset variables if 
> cross-compiling.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/tools/Compile/bin/GetRecipe?cvsroot=goboscripts&r1=1.9&r2=1.10
>
> Patches:
> Index: GetRecipe
> ===================================================================
> RCS file: /sources/goboscripts/tools/Compile/bin/GetRecipe,v
> retrieving revision 1.9
> retrieving revision 1.10
> diff -u -b -r1.9 -r1.10
> --- GetRecipe   25 Jul 2006 19:10:48 -0000      1.9
> +++ GetRecipe   9 Sep 2006 05:25:33 -0000       1.10
> @@ -4,7 +4,12 @@
>  # Imports
>  ##################################################
>
> -unset goboCrossCompiling goboPrefix
> +if [ "$goboCrossCompiling" ]
> +then
> +    unset goboCrossCompiling
> +    unset goboPrefix
> +fi
> +
>  . ScriptFunctions
>  Import OptionParser
>  Import File
> _______________________________________________
> gobolinux-commits mailing list
> [EMAIL PROTECTED]
> http://lists.gobolinux.org/mailman/listinfo/gobolinux-commits
>


-- 
Andre Detsch
_______________________________________________
gobolinux-devel mailing list
[email protected]
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel

Reply via email to