There has been passed some months since we changed the interpretation
of old-style dependencies lines for recipes (recipes, not binary
packages). Instead of considering
  Program X.Y.Z
as
  Program >= X.Y.Z
we started to assume a dependency of
  Program
only (forcing the use of explicit ranges in the case a lower limit is known).

Some additional info at:
http://lists.gobolinux.org/pipermail/gobolinux-devel/2006-July/001255.html

Jonas just pointed me that he was not expecting such behavior, since
he was expecting to be able to define limits without relying on newer
versions of Compile/Scripts.

Part of the problem of dummy (and annoying) versions inside recipes
was reduced, since there has been already some time since Compile
stopped to automatically update the Dependencies file. As the time
passes, dependencies versions automatically added by Compile at the
old times (and not revised) tend to become less annoying, since there
is a higher probability that the user already has updated the version
of the package anyway (so "Program >= OLD_VERSION" becomes almost the
same as "Program").

The question is:
Should we keep dropping the version number of old-style dependencies
lines for recipes? Or should we rollback and interpret "Program X" as
"Program >= X" (like it is being done with binary packages)?


On 7/29/06, André Detsch <[EMAIL PROTECTED]> wrote:
> CVSROOT:        /sources/goboscripts
> Module name:    tools
> Changes by:     André Detsch <detsch>   06/07/29 22:57:14
>
> Modified files:
>         Scripts/bin    : CheckDependencies
>
> Log message:
>         Don't setting a lower limit on installed version when checking 
> dependencies for a recipe and the dependency
>         line (from Dependencies / BuildDependencies) follows the old style 
> (only <program> [version], without ranges).
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/tools/Scripts/bin/CheckDependencies?cvsroot=goboscripts&r1=1.20&r2=1.21
>
> Patches:
> Index: CheckDependencies
> ===================================================================
> RCS file: /sources/goboscripts/tools/Scripts/bin/CheckDependencies,v
> retrieving revision 1.20
> retrieving revision 1.21
> diff -u -b -r1.20 -r1.21
> --- CheckDependencies   29 Jul 2006 22:43:27 -0000      1.20
> +++ CheckDependencies   29 Jul 2006 22:57:14 -0000      1.21
> @@ -53,7 +53,7 @@
>                                 options=line.split("|")
>                                 last_rule = None
>                                 for o in options :
> -                                       rule = interpret_dependency_line(o) # 
> todo: add exception handling
> +                                       rule = interpret_dependency_line(o,t) 
> # todo: add exception handling
>                                         if last_rule :
>                                                 last_rule['option'] = rule
>                                                 last_rule = rule
> @@ -130,14 +130,14 @@
>         sys.stderr.write('Dependencies for %s %s %s %s not found\n'%(p,v,t,u))
>         return []
>
> -def interpret_dependency_line(line) :
> +def interpret_dependency_line(line, t=None) :
>         line = line.split('#')[0].strip()
>         if not line :
>                 return
>
>         m = new_format_c.match(line)
>         if m :
> -               return {'program'    : m.group(1),
> +               ret = {'program'    : m.group(1),
>                         'loincluded' : m.group(2) == '[',
>                         'lover'      : m.group(3),
>                         'hiver'      : m.group(4),
> @@ -146,14 +146,17 @@
>         else :
>                 m = old_format_c.match(line)
>                 if m :
> -                       return {'program'    : m.group(1),
> +                       ret = {'program'    : m.group(1),
>                                 'lover'      : m.group(2),
>                                 'loincluded' : True,
>                                 'hiver'      : '',
>                                 'hiincluded' : False,
>                                 'optional'   : True }
> +                       if t == 'recipe' :
> +                               ret['lover'] = ''
>                 else :
>                         raise Exception("Parse error")
> +       return ret
>
>  #############################################################################
>  # Function that interpret the semantic of the rule,
> _______________________________________________
> gobolinux-commits mailing list
> [EMAIL PROTECTED]
> http://lists.gobolinux.org/mailman/listinfo/gobolinux-commits
>


-- 
Andre Detsch
_______________________________________________
gobolinux-devel mailing list
[email protected]
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel

Reply via email to