2007/1/12, Lucas C. Villa Real <[EMAIL PROTECTED]>:
> On 1/12/07, Jonas Karlsson <[EMAIL PROTECTED]> wrote:
> > > Log message:
> > > Do not specify ${dir}, or else the archives will be made
> > > available at ${dir}/${dir}.
> > >
> > I'm not able to check this atm, but "${dir}" is there to specify what
> > the save directory should be called. With the new implementation, if
> > the URL is e.g. "http://some.host/path/to/app";, the source will be
> > checked out to ${dir}/app. Is this the desired behaviour?
>
> Yes, it is. I was working on the Pentagram recipe, for which its
> dir=pentagram/pentagram/trunk. When using "$svn $dir", svn checkouts
> to Sources/pentagram/pentagram/trunk, creating the final tree
> Sources/pentagram/pentagram/trunk/pentagram/pentagram/trunk. This way,
> 'cd $dir' inside Compile will succeed, but it will fail to see the
> build scripts inside it.
>
I looked at the recipe and I think that dir shouldn't be used that
way. Instead 'svn' should be set to the complete url:
'svn=https://svn.sourceforge.net/svnroot/pentagram/pentagram/trunk/'
Then the old implementation was correct (I think), where, instead of
the new directory created by svn co being 'trunk' it would check out
the source into ${dir} (effectively renaming 'trunk')
> > Else a better implementation would be to drop the 'cd "$savedir"' and
> > change the checkout command to 'svn checkout $svn "${savedir}"'.
>
> Yes, that sounds better indeed. I'm commiting this change now.
>
I checked the source and this new implementation will fail. It will
checkout the source (without containing directory) into ${savedir},
which is passed from Compile as $compileSourcesDir, which, in turn
(iirc), is set to /Files/Compile/Source. So you will end up with
sourcefiles in the Source root folder. The old implementation used the
variable ${dir}, as this is set to "${appname}-${versionnumber}",
where versionnumber is a datestamp and svn tag, versionnumber=`date
+%Y%m%d`"-SVN", as containing directory. Perhaps this should be passed
from Compile as "--save-to"?
Hope I make some sense in the above, I have my hands full of alot of
things atm and don't have time to implement and test the solution.
--
/Jonas
_______________________________________________
gobolinux-devel mailing list
[email protected]
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
