On Fri, Dec 18, 2009 at 6:34 PM, <mohj...@svn.gobolinux.org> wrote:
> Author: mohjive
> Date: 2009-12-18 12:33:59 -0800 (Fri, 18 Dec 2009)
> New Revision: 4242
>
> Modified:
> trunk/ChrootCompile/bin/ChrootCompile
> Log:
> simplify the dependency type logic and use a more descriptive name
>
> Modified: trunk/ChrootCompile/bin/ChrootCompile
> ===================================================================
> --- trunk/ChrootCompile/bin/ChrootCompile 2009-12-18 19:36:25 UTC (rev
> 4241)
> +++ trunk/ChrootCompile/bin/ChrootCompile 2009-12-18 20:33:59 UTC (rev
> 4242)
> @@ -495,9 +495,7 @@
> return $res
> }
>
> -anytype="local_package"
> -[ -z "${norecursive}" ] && anytype="$anytype,recipe"
> -anytype="$anytype,oficial_package"
> +dependencytypes]="local_package,${norecursive+:recipe,}oficial_package"
Isn't this logic inverted? When norecursive is set then we don't want
to include "recipe". When norecursive is empty then we want "recipe"
to be part of dependencytypes. ( I think you entered a typo in
'dependencytypes]=', too )
Also the Bash manual doesn't say anything about "+:", or perhaps that
one was introduced by a later version of it? Bash 4.0.17 manual
suggests ":+" instead.
Thanks,
--
Lucas
"If you're looking for a reason I've a reason to give: pleasure,
little treasure"
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
