Hi, I have been away for a while, but i haven't seen this committed. Should we discuss it more and come up with other ideas or is this an ok way to do it?
On Sun, Aug 1, 2010 at 07:32, Michael Homer <mich...@gobolinux.org> wrote: > On Sat, Jul 31, 2010 at 7:41 AM, Olle <olle.lundb...@gmail.com> wrote: >> On Fri, Jul 30, 2010 at 21:30, Olle <olle.lundb...@gmail.com> wrote: >>> Hi, >>> >>> I am trying to build a package using scons. However, the library in >>> question does not have an install target in it's scons file. The file >>> is generated in the directory you compiles it in. To install this >>> file, i therefore have to write my own do_install() procedure. But >>> instead of having to write my own install rutine, which will be almost >>> identical in functionality to the manifest_do_install() procedure, i >>> would like to utilize what has already been written and declare a >>> manifest array and then call manifest_do_install() in my own >>> do_install() However, Recipelint gets cross with me and tells me that >>> the manifest declaration is not allowed in this recipe type. >>> >>> I have attached the Recipe file in question. >> I am proposing the following patch. > I'm not sure about this. I think I'd be tentatively in favour of it > myself but I know some others have strong feelings about > manifest-based hacks. > > I believe you should be able to declare your manifest inside > do_install(), then call manifest_do_install and have it work. I don't > really think that's less of a hack though, and there is a lot of > clever magic built into the manifest install routine that shouldn't be > needlessly duplicated. If nobody objects I will apply the patch in a > couple of days. > -Michael > _______________________________________________ > gobolinux-devel mailing list > gobolinux-devel@lists.gobolinux.org > http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel > -- Olle _______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
