On Sat, Jul 22, 2017 at 7:08 PM, Howard Guo <guohou...@gmail.com> wrote:
> https://github.com/HouzuoGuo/laitos

It's tangential to your question, but out of curiousity, I skimmed the
source code. In things like func TestUDPServer in
https://github.com/HouzuoGuo/laitos/blob/master/frontend/plain/udp.go,
you say:

var stoppedNormally bool
go func() {
  etc
  stoppedNormally = true
}()
etc
server.Stop()
time.Sleep(1 * time.Second)
if !stoppedNormally { etc }

This is an example of incorrect synchronization as per
https://golang.org/ref/mem#tmp_10

There may be other such races in your code. I didn't do an exhaustive
review. It may be worthwhile to run your test suite under the race
detector.

-- 
You received this message because you are subscribed to the Google Groups 
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to golang-nuts+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to