Hi Konstantin - thanks for your interest! I have not proposed merging it upstream. The x/crypto libraries are fairly slow to evolve, so for experimenting with a new API, an immediate merge is probably not wise.
Since the API adds support for cancelation, it isn't backwards compatible. Merging it would break existing consumers of x/crypto/ssh. That said I'm open to it, but I don't see a good reason for it at this point, since the API is still experimental and needs more use to validate it. It would be possible to merge the leak-fixes and idle-timeout functionality and leave the context support behind without breaking existing users, but... then you give up alot of the control over cancellation. I've mentioned as much on certain tickets, but folks are on summer vacation and there's not been much discussion. https://github.com/golang/go/issues/21423 https://github.com/golang/go/issues/21420 https://github.com/golang/go/issues/20288 After some intense work today, I've fixed all the leaking goroutines from the original test set now. I'm 90% happy with the API, but I'm concerned that the cancelation and timeout functionality in particular could use more experience before declaring the API stable and fixed in place. Please try it and give feedback! Jason On Tuesday, August 29, 2017 at 2:34:34 AM UTC-5, Konstantin Khomoutov wrote: > > On Sat, Aug 26, 2017 at 04:47:04PM -0700, Jason E. Aten wrote: > > > https://github.com/glycerine/xcryptossh > > > > This is an evolution of golang.org/x/crypto/ssh to fix memory leaks, > > provide for graceful shutdown, and implement idle timeouts for each > > multiplexed channel. It is not API backwards compatible because it > provides > > context.Context based cancelation. > > > > Its new so I still consider it experimental. Please try it out and leave > > feedback on github. > > Do you plan intergating this upstream (into golang.org/x/crypto/ssh)? > Or was this proposed upstream and rejected? (If yes, do you care to > provide links to the relevant discussions, if any)? > > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
