Brendan, could you review this and express your vision against the usage of
https://godoc.org/k8s.io/kubernetes/third_party/forked/golang/reflect <https://godoc.org/k8s.io/kubernetes/third_party/forked/golang/reflect> https://golang.org/pkg/reflect/ https://github.com/modern-go/reflect2 packages? What is required to patch, within the reflect2 package, so Kubernetes could be compiled via gollvm? Ivan On Sat, Jul 20, 2019 at 5:32 AM Yuan Ting <yuant...@ict.ac.cn> wrote: > OK, I will check out the reflect2 package and take a look. Thanks a lot > for your direction! > > Best, > Ting > > On Friday, July 19, 2019 at 10:30:32 PM UTC+8, Ian Lance Taylor wrote: >> >> On Fri, Jul 19, 2019 at 1:11 AM Yuan Ting <yuan...@ict.ac.cn> wrote: >> > >> > Sorry to have troubled you again, I found that many famous Go projects >> also import github.com/modern-go/reflect2 , such as kubernetes and moby. >> According to the second paragraph in your explanation, these popular >> projects will also failed in compilation. I think this may be a big >> challenge for gccgo/gollvm's promotion. >> > >> > To solve this compiler-sensitive problem, the way I can come up with is >> replacing all unsafe mechanisms as mentioned above in reflect2 to safe or >> standard mechanisms (and may go against the purpose of reflect2). I'm not >> familiar with runtime, but is it possible to support the same symbol in >> gccgo/gollvm style? >> >> Simply supporting runtime.typelinks is not enough. The reflect >> package is closely tied to the compiler implementation. The reflect >> package is not identical in the gc library and the GoLLVM library. If >> people need reflect2 to work with GoLLVM, then the only workable >> option is for the reflect2 authors to write a version of their package >> that uses the gccgo build tag to build a version that works with >> GoLLVM. Perhaps you could help them with that. Sorry this isn't very >> helpful. I don't really understand why people are using the package. >> >> Ian >> > -- > You received this message because you are subscribed to the Google Groups > "golang-nuts" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-nuts+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/golang-nuts/1fd95c73-6e30-4089-bad4-b21c261d788a%40googlegroups.com > <https://groups.google.com/d/msgid/golang-nuts/1fd95c73-6e30-4089-bad4-b21c261d788a%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CANFCsz_Ropfv93%2B_g%3DsPCa_yzrQuQJSQcWTjvLbTB-GcMhBkyw%40mail.gmail.com.
