There is no good reason that proper behavior should be dependent on understanding best practices. It should help with readability not correctness. Seems to me the compiler or Go Vet should prohibit this - in my review of the stdlib and other projects I can’t see any reason why it doesn’t.
> On Jun 6, 2021, at 11:10 AM, jake...@gmail.com <jake6...@gmail.com> wrote: > > On Sunday, June 6, 2021 at 9:33:31 AM UTC-4 ren...@ix.netcom.com wrote: >> For example, the fact that this code is broken is not intuitively obvious >> for any reader. It requires way too much scrutiny IMO. >> >> https://play.golang.org/p/-f73t_Pm7ur > > I would like to note that your example goes against the general advice that > all methods should be on either pointers or values. Mixing value and pointer > methods for the same types is a code smell. The code you posted is a good > example of one of the reasons why. > > The second to last paragraph in the FAQ section > https://golang.org/doc/faq#methods_on_values_or_pointers says: > "If some of the methods of the type must have pointer receivers, the rest > should too, so the method set is consistent regardless of how the type is > used." > > In your example, if MyEventRecorder.Log() is changed to have a pointer > receiver, then the code works as expected: > https://play.golang.org/p/MG10opC6Ect > > -- > You received this message because you are subscribed to the Google Groups > "golang-nuts" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-nuts+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/golang-nuts/a9b4a8b3-0b2f-4935-807e-1cbca03a3b20n%40googlegroups.com. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/7C376006-EFA0-44BA-A036-B768078E4AA4%40ix.netcom.com.
