On Wed, Nov 24, 2021 at 6:14 PM Fannie Zhang <fannie.zh...@arm.com> wrote:
> Hi all, > > There is some incorrect code in > https://go.dev/blog/defer-panic-and-recover blog. > > The original code is > *func CopyFile() {* > * ...* > * if err != nil {* > * return* > * }* > * defer src.Close()* > * ...* > *}* > > I think the correct code should be > *func CopyFile() {* > * ...* > * defer src.Close()* > * if err != nil {* > * return* > * }* > * ...* > *}* > > I do not know how to modify the go blog, can anyone help? Thank you. > Well, I would call myself a Go newbie, but I would think that if err != nil, that means there was an error, so the value of "src" would be either invalid or nil, so putting the "defer" before the err check would possibly result in a panic. I'd say the original code is correct. > Best regards, > Fannie Zhang > > -- > You received this message because you are subscribed to the Google Groups > "golang-nuts" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-nuts+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/golang-nuts/726e95ed-9b14-46a5-bb09-7821616f4ff9n%40googlegroups.com > <https://groups.google.com/d/msgid/golang-nuts/726e95ed-9b14-46a5-bb09-7821616f4ff9n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAA5t8Vp4-dYHApveOObvQMXqg0s%2B_8Lu1WhCDKgyB8rst9cytw%40mail.gmail.com.
