Thanks that was very helpful. As for your point about slog, yes a custom handler could but I am using the library json handler.
I suppose the proper way to frame my problem is that I am using the slog library handler and I do not want new lines in the message or keys. Would the go team would be open to providing knobs to control how the handler does formatting? I assumed if I tried opening a proposal like that I’d be told to write a custom handler. :) On Mon, Aug 7, 2023 at 3:56 PM Ian Lance Taylor <i...@golang.org> wrote: > On Mon, Aug 7, 2023 at 4:32 AM jal...@gmail.com <jalo...@gmail.com> wrote: > > > > In the errors.join proposal, the proposed api had the user specify how > they wanted the errors to be formatted together. But the actual > implementation omitted and only used new line. > > > > This is quite unfortunate if you are using slog and want to log that > error and very much need a log statement to not span multiple lines. It > also makes it much harder to read. > > > > Does anyone recall why sep was dropped? > > See the discussion at https://go.dev/issue/53435, especially > https://github.com/golang/go/issues/53435#issuecomment-1190654775 and > https://github.com/golang/go/issues/53435#issuecomment-1190845424. > > As far as the slog package it seems to me that a handler can enforce > that individual messages are on a single line. There may be a better > way to address that problem, but I don't think that errors.Join is the > right place for a fix. Any random package can generate multiline > error messages with errors.New("a\nb"), and I've seen plenty that do. > So enforcing single-line messages on errors.Join won't fix the problem > in general. > > Ian > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAMvD0VK7JkStS-wuFmkmBROh0f5WbcNuAD-sHDynS0Oq8CS%2B1Q%40mail.gmail.com.
