Reviewers: MarkM,

Description:
Ihab and Mark realized that it's easier to do things like renderers
with original source line mappings if all the renderers bottom out in
a Concatenator instead of in an Appendable.

This changes the API to make that a fact, though the pretty and
minimal JS printers do not yet forward FilePositions through to the
Concatenator too.

Please review this at http://codereview.appspot.com/53101

Affected files:
  M     src/com/google/caja/lang/css/CssPropertyPatterns.java
  M     src/com/google/caja/lang/html/HtmlDefinitions.java
  M     src/com/google/caja/opensocial/DefaultGadgetRewriter.java
  M     src/com/google/caja/opensocial/GadgetParser.java
  M     src/com/google/caja/opensocial/applet/CajaApplet.java
  M     src/com/google/caja/parser/css/CssPropertySignature.java
  M     src/com/google/caja/parser/css/CssTree.java
  M     src/com/google/caja/parser/html/Nodes.java
  M     src/com/google/caja/parser/js/AbstractExpression.java
  M     src/com/google/caja/parser/js/AbstractStatement.java
  M     src/com/google/caja/parser/js/CajoledModule.java
  M     src/com/google/caja/parser/js/Identifier.java
  M     src/com/google/caja/parser/js/Minify.java
  M     src/com/google/caja/parser/js/UncajoledModule.java
  M     src/com/google/caja/parser/js/UseSubset.java
  M     src/com/google/caja/parser/quasiliteral/Rewriter.java
  M     src/com/google/caja/plugin/BuildServiceImplementation.java
  M     src/com/google/caja/plugin/CssCompiler.java
  M     src/com/google/caja/plugin/CssRewriter.java
  M     src/com/google/caja/plugin/CssValidator.java
  M     src/com/google/caja/plugin/HtmlCompiler.java
  M     src/com/google/caja/plugin/PluginCompilerMain.java
  M     src/com/google/caja/render/AbstractRenderer.java
  M     src/com/google/caja/render/BufferingRenderer.java
  M     src/com/google/caja/render/Concatenator.java
  M     src/com/google/caja/render/CssPrettyPrinter.java
  M     src/com/google/caja/render/Innocent.java
  M     src/com/google/caja/render/JsLinePreservingPrinter.java
  M     src/com/google/caja/render/JsMinimalPrinter.java
  M     src/com/google/caja/render/JsPrettyPrinter.java
  M     src/com/google/caja/render/SourceSnippetRenderer.java
  M     src/com/google/caja/render/SourceSpansRenderer.java
  M     src/com/google/caja/render/TabularSideBySideRenderer.java
  M     src/com/google/caja/reporting/RenderContext.java
  M     tests/com/google/caja/opensocial/DefaultGadgetRewriterTest.java
  M     tests/com/google/caja/parser/ParseTreeNodeTest.java
  M     tests/com/google/caja/parser/css/CssTreeTest.java
  M     tests/com/google/caja/parser/js/ParserTest.java
  M     tests/com/google/caja/parser/quasiliteral/ModuleFormatTest.java
  M     tests/com/google/caja/plugin/CssCompilerTest.java
  M     tests/com/google/caja/plugin/DomProcessingEventsTestData.java
  M     tests/com/google/caja/plugin/HtmlCompiledPluginTest.java
  M     tests/com/google/caja/plugin/HtmlSanitizerTest.java
  M     tests/com/google/caja/plugin/stages/PipelineStageTestCase.java
  M     tests/com/google/caja/render/JsLinePreservingPrinterTest.java
  M     tests/com/google/caja/render/JsMinimalPrinterTest.java
  M     tests/com/google/caja/render/JsPrettyPrinterTest.java
  M     tests/com/google/caja/util/CajaTestCase.java
  M     tests/com/google/caja/util/RhinoTestBed.java


Reply via email to