http://codereview.appspot.com/96177/diff/7064/6069 File src/com/google/caja/cajita-module.js (right): http://codereview.appspot.com/96177/diff/7064/6069#newcode92 Line 92: handle: ___.markFuncFreeze(function theHandler(module) { On 2009/08/20 22:10:58, ihab.awad wrote:
As we discussed, this function should exit without doing anything if
it detects
"savedHead !== head".
Done. http://codereview.appspot.com/96177/diff/7064/6069#newcode107 Line 107: function timeout(p) { On 2009/08/20 22:10:58, ihab.awad wrote:
As we discussed, this does not need a param -- just use "savedHead".
Also add a
comment clarifying the case where "savedHead !== head".
Done. http://codereview.appspot.com/96177/diff/7064/6069#newcode118 Line 118: var savedHead = head; On 2009/08/20 22:10:58, ihab.awad wrote:
As we discussed, move savedHead up ....
Done. http://codereview.appspot.com/96177/diff/7064/6069#newcode122 Line 122: timeout(savedHead); On 2009/08/20 22:10:58, ihab.awad wrote:
As we discussed, script.onerror and script.onreadystatechange should
*both* do
"script.onerror = script.onreadystatechange = null" to clear things
out. Done. http://codereview.appspot.com/96177/diff/7064/6075 File src/com/google/caja/valija-cajita.js (right): http://codereview.appspot.com/96177/diff/7064/6075#newcode500 Line 500: On 2009/08/20 21:07:16, ihab.awad wrote:
Again, this looks like a spurious diff.
Done. http://codereview.appspot.com/96177/diff/7064/6075#newcode521 Line 521: On 2009/08/20 21:07:16, ihab.awad wrote:
Extra whitespace on this line.
Done. http://codereview.appspot.com/96177/diff/7064/6066 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/96177/diff/7064/6066#newcode2683 Line 2683: function testScriptModuleLoader2() { On 2009/08/20 21:07:16, ihab.awad wrote:
Indentation (and in a couple other places in this file).
Done. http://codereview.appspot.com/96177
